Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid RowDefinitions/ColumnDefinitions breaks hot reload in VS 2022 #6371

Closed
1 of 2 tasks
asklar opened this issue Nov 23, 2021 · 6 comments
Closed
1 of 2 tasks

Grid RowDefinitions/ColumnDefinitions breaks hot reload in VS 2022 #6371

asklar opened this issue Nov 23, 2021 · 6 comments
Labels
area-Commanding AppBar, UICommand, MVVM, etc bug Something isn't working product-winui3 WinUI 3 issues team-Markup Issue for the Markup team

Comments

@asklar
Copy link
Member

asklar commented Nov 23, 2021

Describe the bug

This might be related to #6370 but since this is another aspect of the break, filing separately

Steps to reproduce the bug

<Grid RowDefinitions="123,*">
...
</Grid>

Expected behavior

No response

Screenshots

No response

NuGet package version

WinUI 3 - Windows App SDK 1.0 (If you're seeing your issue in older previews of WinUI 3, please try this release)

Windows app type

  • UWP
  • Win32

Device form factor

No response

Windows version

Insider Build (xxxxx)

Additional context

No response

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Nov 23, 2021
@MikeHillberg MikeHillberg added team-Markup Issue for the Markup team product-winui3 WinUI 3 issues and removed needs-triage Issue needs to be triaged by the area owners labels Nov 23, 2021
@sonnemaf
Copy link
Contributor

I can confirm this.

image

<Grid Margin="4"
        ColumnDefinitions="1*,1*"
        ColumnSpacing="4"
        RowDefinitions="1*,1*"
        RowSpacing="4">
    <Rectangle Fill="#F25022" />
    <Rectangle Grid.Column="1"
                Fill="#7FBA00" />
    <Rectangle Grid.Row="1"
                Fill="#00A4EF" />
    <Rectangle Grid.Row="1"
                Grid.Column="1"
                Fill="#FFB900" />
</Grid>

@wbokkers
Copy link

I reported this already here: #5944

@HEIC-to-JPEG-Dev
Copy link

This means that there is effectively no visual editor for WinUI if you use this XAML as VS doesn't have one, and hot reload doesn't work as it doesn't recognise the XAML if any part is modified.

@github-actions
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@sbaeumlisberger
Copy link

The problem still exists with Windows App SDK 1.3

@duncanmacmichael duncanmacmichael added bug Something isn't working area-Commanding AppBar, UICommand, MVVM, etc labels Oct 31, 2023
@JesseCol
Copy link

As wbokkers says, looks like a dupe of #5944 , closing.

@JesseCol JesseCol closed this as not planned Won't fix, can't repro, duplicate, stale Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Commanding AppBar, UICommand, MVVM, etc bug Something isn't working product-winui3 WinUI 3 issues team-Markup Issue for the Markup team
Projects
None yet
Development

No branches or pull requests

8 participants