Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt shared quick pick from platform (Go to line, Go to symbol, Commands) #1874

Closed
bpasero opened this issue Mar 16, 2020 · 1 comment
Closed
Assignees
Labels
feature-request Request for new features or functionality quick-pick
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Mar 16, 2020

This is a result of microsoft/vscode#69955. A couple of quick pick providers will be shared between editor and workbench:

  • Go to symbol in file
  • Go to line
  • Commands

As such the experience has slightly changed:

  • there is now also a quick way to switch from one provider to the other in the standalone editor by changing the prefix
  • background color is the typical editor widget background
  • visually looking the same (e.g. commands keybindings)

Kapture 2020-03-16 at 15 20 51

All commands have been updated to point to the new solution and the old quick open has been deleted from the standalone editor.

//cc @alexdima @rebornix

@bpasero bpasero added feature-request Request for new features or functionality quick-pick labels Mar 16, 2020
@bpasero bpasero added this to the March 2020 milestone Mar 16, 2020
@bpasero bpasero self-assigned this Mar 16, 2020
@bpasero bpasero closed this as completed Mar 16, 2020
@alexdima
Copy link
Member

This is great, thank you! 🎉🎉🎉

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality quick-pick
Projects
None yet
Development

No branches or pull requests

2 participants