Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official Linux Packages aren't Being Built with numa.h #3619

Closed
1 of 4 tasks
nibanks opened this issue May 10, 2023 · 1 comment
Closed
1 of 4 tasks

Official Linux Packages aren't Being Built with numa.h #3619

nibanks opened this issue May 10, 2023 · 1 comment

Comments

@nibanks
Copy link
Member

nibanks commented May 10, 2023

Describe the bug

Setting up libmsquic (2.2.1) ...
furt@ubu20:~/github/msquic/src$ ldd /usr/lib/x86_64-linux-gnu/libmsquic.so.2
    linux-vdso.so.1 (0x00007ffebc393000)
    libcrypto.so.1.1 => /lib/x86_64-linux-gnu/libcrypto.so.1.1 (0x00007f24730ef000)
    libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f24730e9000)
    libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f24730c6000)
    libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f2472ed4000)
    /lib64/ld-linux-x86-64.so.2 (0x00007f2473539000)

@wfurt pointed out that our 2.2.1 packages don't actually have the libnuma dependency and I just checked our build pipeline and I see:

-- Found libnuma: /usr/lib/x86_64-linux-gnu/libnuma.so.1
-- numa.h not found. If build fails, install libnuma-dev

I don't know why it can find libnuma.so but not numa.h. We build the docker container with libnuma-dev installed, so it should have everything we need, but apparently it doesn't?

Affected OS

  • Windows
  • Linux
  • macOS
  • Other (specify below)

Additional OS information

No response

MsQuic version

v2.2

Steps taken to reproduce bug

Run official Linux builds

Expected behavior

Depends on libnuma

Actual outcome

No libnuma dependency because it wasn't fully available at build time.

Additional details

No response

@csujedihy
Copy link
Contributor

It's been fixed by #3620.

jedihy@HUANYI-DEV ~> ldd libmsquic.so.2.3.0
        linux-vdso.so.1 (0x00007ffd54fbc000)
        libcrypto.so.1.1 => /lib/x86_64-linux-gnu/libcrypto.so.1.1 (0x00007f0c1e3dd000)
        libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f0c1e3d7000)
        libnuma.so.1 => /lib/x86_64-linux-gnu/libnuma.so.1 (0x00007f0c1e3ca000)
        libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f0c1e3a7000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f0c1e1b5000)
        /lib64/ld-linux-x86-64.so.2 (0x00007f0c1e81c000)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants