Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Bugfix for nnictl #1949

Closed
tyusr opened this issue Jan 13, 2020 · 3 comments
Closed

Bugfix for nnictl #1949

tyusr opened this issue Jan 13, 2020 · 3 comments

Comments

@tyusr
Copy link
Contributor

tyusr commented Jan 13, 2020

Bugfix for nnictl experiment delete <experiment_id>:

in nni/tools/nni_cmd/config_utils.py line 79:

def remove_experiment(self, expId):
'''remove an experiment by id'''
if id in self.experiments:
self.experiments.pop(expId)
self.write_file()

id should be expId

@scarlett2018
Copy link
Member

Bugfix for nnictl experiment delete <experiment_id>:

in nni/tools/nni_cmd/config_utils.py line 79:

def remove_experiment(self, expId):
'''remove an experiment by id'''
if id in self.experiments:
self.experiments.pop(expId)
self.write_file()

id should be expId

would you like to submit a PR? =).

@tyusr
Copy link
Contributor Author

tyusr commented Jan 14, 2020

Bugfix for nnictl experiment delete <experiment_id>:
in nni/tools/nni_cmd/config_utils.py line 79:

def remove_experiment(self, expId):
'''remove an experiment by id'''
if id in self.experiments:
self.experiments.pop(expId)
self.write_file()

id should be expId

would you like to submit a PR? =).

Done. #1953

@QuanluZhang
Copy link
Contributor

Thanks for your contribution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants