Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Should Support the TupleUnpack/ListUnpack in TorchModuleGraph #2581

Closed
zheng-ningxin opened this issue Jun 19, 2020 · 1 comment
Closed

Should Support the TupleUnpack/ListUnpack in TorchModuleGraph #2581

zheng-ningxin opened this issue Jun 19, 2020 · 1 comment

Comments

@zheng-ningxin
Copy link
Contributor

Environment:

  • NNI version: master(latest)
  • NNI mode (local|remote|pai): local
  • Server OS (for remote mode only): Ubuntu16.04
  • Python version: 3.7
  • PyTorch/TensorFlow version: 1.4.0
  • Is conda/virtualenv/venv used?: yes
  • Is running in Docker?: no

What issue meet, what's expected?:
Because NNI does not have special treatment for TupleUnpack and ListUnpack operations, TorchModuleGraph will have a graph construction error in some models with TupleUnpack and ListUnpack operations(such as retina face/shufflenet). I want to support these operations in the next release and fix this problem.

How to reproduce it?:
Take shufflenet as an example. The TorchModuleGraph will build the graph in the wrong way(as shown in the following img).
image

In contrast, the right way to build the graph of the shufflenet is shown in the following graph.
image

Additional information:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants