Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Adopt moodle-plugin-ci usage in this repository #2536

Open
5 tasks done
joaop221 opened this issue Mar 21, 2024 · 4 comments · Fixed by #2610, #2611, #2612 or #2613
Open
5 tasks done

CI: Adopt moodle-plugin-ci usage in this repository #2536

joaop221 opened this issue Mar 21, 2024 · 4 comments · Fixed by #2610, #2611, #2612 or #2613
Assignees
Labels
Issue type - enhancement request New feature being requested outside of original scope.

Comments

@joaop221
Copy link
Contributor

joaop221 commented Mar 21, 2024

Hi @weilai-irl, while applying new releases at my moodle internal repository, I've checked a unit test fail.

To minimize this problem, it could be conveniente adopt moodle-plugin-ci usage in public repository.

I'll try to make this implementation here, but I don't know if this is a relevant idea for this repository.

Regards, JP.

Tasks

@joaop221
Copy link
Contributor Author

@weilai-irl weilai-irl self-assigned this Jun 7, 2024
@weilai-irl
Copy link
Collaborator

Hi @joaop221

Thank you for making the recommendation. I agree this is a very good idea, and it should be the way to go.

I'll discuss with our team to make a formal decision on this. Considering the amount of errors, this may take some time. Please bare with us.

Regards,
Lai

@joaop221
Copy link
Contributor Author

Hi @weilai-irl

Apologies for not replying sooner. I've reviewed the implementation and am pleased that the foundational implementation is beneficial for the project.

Do you need help to reduce problems reported by moodle-plugin-ci?

@weilai-irl
Copy link
Collaborator

Hi @joaop221

No worries at all. We are busy with other tasks as well. The changes will be pushed live in the next release, which is expected before the end of September. I have seen the results of the checks and they look extremely helpful. I'm really looking forward for these changes.

Regarding the issues/warnings reported, we want to plan a short sprint to fix some (hopefully most) of them in a special release after these changes are released, and look after the rest in small chunks in future releases. We may need help then. Your help is very much appreciated.

Regards,
Lai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment