Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CircleCI] E2E Tests fail #949

Closed
Saadnajmi opened this issue Jan 10, 2022 · 8 comments
Closed

[CircleCI] E2E Tests fail #949

Saadnajmi opened this issue Jan 10, 2022 · 8 comments
Labels
bug Something isn't working Stale

Comments

@Saadnajmi
Copy link
Collaborator

Environment

react-native -v:
npm ls react-native-macos:
node -v:
npm -v:
yarn --version:
xcodebuild -version:

Steps to reproduce the bug

This seems to be because the E2E tests are downloading react-native version 0.63 from NPM and testing against that, instead of using the local copy. #944 Might help with this, but I commented out the failing check in #945 . This bug is to track.

Expected Behavior

No response

Actual Behavior

No response

Reproducible Demo

No response

Additional context

No response

@Saadnajmi Saadnajmi added the bug Something isn't working label Jan 10, 2022
@ghost ghost added the Needs: Triage 🔍 label Jan 10, 2022
@HeyImChris
Copy link

Thanks for tracking the CI diff we have. Can leave this open until we resolve that in the CircleCI.

@kelset
Copy link

kelset commented Mar 28, 2022

@Saadnajmi I think we can close this one, as far as I can tell it's fixed right? (at least on main the test is now uncommented again)

@Saadnajmi
Copy link
Collaborator Author

I only disabled the tests, I didn't fix them.

@kelset
Copy link

kelset commented Mar 28, 2022

commit with the actual disabling of the test: https://github.com/microsoft/react-native-macos/pull/1052/files (posting for cross-reference)

@kelset
Copy link

kelset commented Mar 29, 2022

update on this: I've investigated this problem a bit more with #1106. The long story short is that this is a problem that spawns from upstream, and that was only tackled in the react-native core repo in December 2021. So we'll only get access to the fixes when catching up to 0.68.

So basically we should not look into this problem until after react-native-macos has caught up to that. For some reason cherry-picking the specific commits don't address the issue on this repo so I'd imagine there's some other commit that is not directly related to the files I've been looking into; anyway it seems that it's not necessary to work further on this but just try to uncomment that CI block after we are on 68

@Saadnajmi
Copy link
Collaborator Author

Thanks for the update @kelset !

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 3, 2023
@github-actions
Copy link

This issue was closed because it has been stalled for 7 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale
Projects
None yet
Development

No branches or pull requests

3 participants