Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextInput focusable property should match react-native #10015

Open
TatianaKapos opened this issue May 27, 2022 · 5 comments
Open

TextInput focusable property should match react-native #10015

TatianaKapos opened this issue May 27, 2022 · 5 comments
Labels
Area: TextInput enhancement Needs: Dev Design Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs.
Milestone

Comments

@TatianaKapos
Copy link
Contributor

Problem Description

When TextInput has "focusable = false" you can't edit/copy/paste from it while you can in IOS/Android (and it looks like Web has no implementation of focusable).

On RNW, focusable to mapped to isTabStop and isEnabled (with isTabStop making the TextInput not being able to tab through or edit). Focusable is also the only way to access isEnabled and the visuals that come with it. We should discuss what properties we want focusable to be linked too for TextInput and if there's a better property to expose isEnabled.

Steps To Reproduce

  1. Set any TextInput to with focusable = false, you won't be able to edit it

Expected Results

You should be able to edit a TextInput with focusable="false"

CLI version

npx react-native --version

Environment

npx react-native info

Target Platform Version

10.0.19041

Target Device(s)

Desktop

Visual Studio Version

Visual Studio 2019

Build Configuration

Debug

Snack, code example, screenshot, or link to a repository

https://snack.expo.dev/@tatianak/textinput-focusable

@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label May 27, 2022
@chrisglein
Copy link
Member

Potentially related: #9826 #9327.
@TatianaKapos can you build out a little table of what each platform is doing and what Windows is doing so it's clear what is wrong with Windows vs. what could be wrong with other platforms.

@chrisglein chrisglein added Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) enhancement and removed bug Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Jun 2, 2022
@ghost ghost added the no-recent-activity Issue/PR has gone stale and may be closed (label applied by bot) label Jun 9, 2022
@ghost
Copy link

ghost commented Jun 9, 2022

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@ghost ghost closed this as completed Jun 16, 2022
@AgneLukoseviciute
Copy link
Contributor

Looks like this was unintentionally closed out, @TatianaKapos fyi. Reopening it.

@ghost ghost removed the no-recent-activity Issue/PR has gone stale and may be closed (label applied by bot) label Aug 23, 2022
@ghost ghost added the no-recent-activity Issue/PR has gone stale and may be closed (label applied by bot) label Aug 30, 2022
@ghost
Copy link

ghost commented Aug 30, 2022

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@AgneLukoseviciute AgneLukoseviciute removed Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) no-recent-activity Issue/PR has gone stale and may be closed (label applied by bot) labels Aug 30, 2022
@AgneLukoseviciute AgneLukoseviciute added this to the Backlog milestone Aug 30, 2022
@AgneLukoseviciute
Copy link
Contributor

Putting it on the backlog so this doesn't get closed out again.

@TatianaKapos TatianaKapos removed their assignment Oct 26, 2023
@chiaramooney chiaramooney added the Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs. label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: TextInput enhancement Needs: Dev Design Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs.
Projects
None yet
Development

No branches or pull requests

4 participants