Defork JSIDynamic.cpp and JSIDynamic.h

[TatianaKapos]

Problem Description

Recent integration updated brough in this PR which updated JSIDynamic.cpp and JSIDynamic.h. For some reason, some of our build configurations don't update those files and still pulls in the old versions. Currently fixed this by forcing them to use the new files by adding an override but we should figure out a way to defork these files.

List of failing tests (Looks like mostly Fabric on Hermes)

My suspicion is hermes-windows holds onto the old versions of these files https://github.com/microsoft/hermes-windows/blob/main/API/jsi/jsi/JSIDynamic.cpp and needs to be updated.

Steps To Reproduce

1. remove override for JSIDYnamic
2. run pipeline

Expected Results

should run fine

CLI version

npx react-native -v

Environment

npx react-native info

Target Platform Version

10.0.19041

Target Device(s)

Desktop

Visual Studio Version

Visual Studio 2022

Build Configuration

Debug

Snack, code example, screenshot, or link to a repository

No response

[TatianaKapos]

Could also be pulling from: https://github.com/microsoft/node-api-jsi/blob/main/jsi/jsi/JSIDynamic.cpp

[chrisglein]

@vmoroz It sounds like Hermes and RNW are fighting over overrides to these files. Is this an issue where the versions need to be in sync and aren't? What's the right way to proceed so that they line up.

[TatianaKapos]

closing! Fixed in #12571