[rush] Don't try to upload a cache entry to Azure Storage if it already exists. #2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
apostolisms,
D4N14L,
halfnibble,
octogonz and
sachinjoseph
as code owners
iclanton
force-pushed
the
ianc/check-if-blob-exists
branch
from
66628bd
to
2a48e5c
Compare
halfnibble
approved these changes
Feb 15, 2021
D4N14L
approved these changes
Feb 15, 2021
iclanton
force-pushed
the
ianc/check-if-blob-exists
branch
from
2a48e5c
to
3c09a09
Compare
dmichon-msft
approved these changes
Mar 2, 2021
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a CI job that populates our Azure Storage cache. It occasionally fails if two jobs run at the same time and both try to upload the same blob cache entry to Azure.
This change checks if the blob exists right before trying to upload. If the blob exists, we'll consider the upload "successful" because it would have been filled from cache if it had existed when the project's build started.