Logical in CreateLocation(LocationVersionOne) looks weird/broken

[michaelcfanning]

Two issues. We shouldn't be setting logical location index to 0 in cases where we can't find the logical location in the index map (we should be setting -1 in this case or possibly erroring out). also, the conditional around decorated name doesn't make obvious sense.

                    _logicalLocationToIndexMap.TryGetValue(logicalLocation, out int index);

                    if (!string.IsNullOrEmpty(logicalLocation.DecoratedName))
                    {
                        logicalLocation.DecoratedName = v1Location.DecoratedName;
                        _logicalLocationToIndexMap[logicalLocation] = index;
                    }

                    location.LogicalLocationIndex = index;