Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileRegionsCache multiline context region generation needs a look. #2617

Open
michaelcfanning opened this issue Feb 13, 2023 · 0 comments
Open

Comments

@michaelcfanning
Copy link
Member

the FileRegionsCache multiline context generation is pretty idiosyncratic. Some considerations:

  • The code that executes is conditional depending on whether the input region is driven by startLine or charOffset conventions. It would be useful to minimize testable surface area if we can by simplifying.
  • There is a distinction between minified/non-minified code.
  • There appear to be some distinctions depending on the size of the input context region itself (i.e., is it greater/lesser than the large snippet size of 512 bytes.

The behavior of the relevant api ConstructMultilineContextSnippet needs to be clearly specified. Tests need to be updated to reflect and test expecations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant