Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: [KernelPromptTemplate] Support primitives in values #4015

Closed
SergeyMenshykh opened this issue Dec 5, 2023 · 2 comments
Closed

.Net: [KernelPromptTemplate] Support primitives in values #4015

SergeyMenshykh opened this issue Dec 5, 2023 · 2 comments
Assignees
@markwallace-microsoft
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) stale Issue is stale because it has been open for 90 days with no activity

Comments

@SergeyMenshykh
Copy link
Member

Today, 'KernelPromptTemplate' requires all values, such as 28 in the expression {{p.f a='28'}}, to be wrapped in single or double quotes. Considering that it's being updated to support primitives - #4013, it would be logical to expect the expression to be like this: {{p.f a=28}}, where the value 28 is specified without single or double quotes and eventually passed to the function as is, without unnecessary string-to-int conversion.
@SergeyMenshykh SergeyMenshykh converted this from a draft issue Dec 5, 2023
@shawncal shawncal added .NET Issue or Pull requests regarding .NET code triage labels Dec 5, 2023
@markwallace-microsoft markwallace-microsoft added v1 bugbash v1.0.1 Required for the Semantic Kernel v1.0.1 release and removed triage labels Dec 6, 2023
@markwallace-microsoft markwallace-microsoft moved this to Sprint: Planned in Semantic Kernel Dec 6, 2023
@evchaki evchaki added the sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) label Dec 11, 2023
@markwallace-microsoft markwallace-microsoft added vnext and removed v1 bugbash v1.0.1 Required for the Semantic Kernel v1.0.1 release labels Dec 14, 2023
@matthewbolanos matthewbolanos added the kernel Issues or pull requests impacting the core kernel label Jan 2, 2024
@markwallace-microsoft markwallace-microsoft moved this from Sprint: Planned to Backlog in Semantic Kernel Oct 7, 2024
@markwallace-microsoft
Copy link
Member

Moving to backlog until we get feedback from customers that this change is required

@markwallace-microsoft markwallace-microsoft added the stale Issue is stale because it has been open for 90 days with no activity label Nov 25, 2024
@markwallace-microsoft
Copy link
Member

Closing as stale

@github-project-automation github-project-automation bot moved this from Backlog to Sprint: Done in Semantic Kernel Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markwallace-microsoft markwallace-microsoft

Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) stale Issue is stale because it has been open for 90 days with no activity
Projects
Semantic Kernel
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@matthewbolanos @shawncal @evchaki @SergeyMenshykh @markwallace-microsoft