diff --git a/src/cascadia/TerminalCore/Terminal.cpp b/src/cascadia/TerminalCore/Terminal.cpp index d58ca2fb032..2d7dd5d424d 100644 --- a/src/cascadia/TerminalCore/Terminal.cpp +++ b/src/cascadia/TerminalCore/Terminal.cpp @@ -178,18 +178,6 @@ void Terminal::UpdateSettings(winrt::Microsoft::Terminal::Settings::ICoreSetting proposedTop -= (proposedBottom - bufferSize.Y); } - Cursor& cursor = _buffer->GetCursor(); - auto cursorPosition = cursor.GetPosition(); - - // If the cursor is positioned beyond the range of the viewport, then - // set the cursor position to a legal value. - cursorPosition.X = std::min(cursorPosition.X, static_cast(viewportSize.X - 1)); - cursorPosition.Y = std::min(cursorPosition.Y, static_cast(viewportSize.Y - 1)); - - cursor.StartDeferDrawing(); - cursor.SetPosition(cursorPosition); - cursor.EndDeferDrawing(); - _mutableViewport = Viewport::FromDimensions({ 0, proposedTop }, viewportSize); _scrollOffset = 0; _NotifyScrollEvent(); @@ -437,11 +425,6 @@ void Terminal::_WriteBuffer(const std::wstring_view& stringView) } } - if (proposedCursorPosition.X > bufferSize.RightInclusive()) - { - proposedCursorPosition.X = 0; - } - // If we're about to scroll past the bottom of the buffer, instead cycle the buffer. const auto newRows = proposedCursorPosition.Y - bufferSize.Height() + 1; if (newRows > 0) @@ -550,8 +533,6 @@ void Terminal::_InitializeColorTable() // - isVisible: whether the cursor should be visible void Terminal::SetCursorVisible(const bool isVisible) noexcept { - auto lock = LockForWriting(); - auto& cursor = _buffer->GetCursor(); cursor.SetIsVisible(isVisible); } diff --git a/src/cascadia/TerminalCore/Terminal.hpp b/src/cascadia/TerminalCore/Terminal.hpp index e565b17a9ec..56f86c2420b 100644 --- a/src/cascadia/TerminalCore/Terminal.hpp +++ b/src/cascadia/TerminalCore/Terminal.hpp @@ -11,7 +11,6 @@ #include "../../terminal/input/terminalInput.hpp" #include "../../types/inc/Viewport.hpp" -#include "../../types/inc/GlyphWidth.hpp" #include "../../types/IUiaData.h" #include "../../cascadia/terminalcore/ITerminalApi.hpp" #include "../../cascadia/terminalcore/ITerminalInput.hpp" diff --git a/src/cascadia/TerminalCore/terminalrenderdata.cpp b/src/cascadia/TerminalCore/terminalrenderdata.cpp index 5a2430d3751..d34c557b84f 100644 --- a/src/cascadia/TerminalCore/terminalrenderdata.cpp +++ b/src/cascadia/TerminalCore/terminalrenderdata.cpp @@ -92,9 +92,7 @@ COLORREF Terminal::GetCursorColor() const noexcept bool Terminal::IsCursorDoubleWidth() const noexcept { - const auto position = _buffer->GetCursor().GetPosition(); - TextBufferTextIterator it(TextBufferCellIterator(*_buffer, position)); - return IsGlyphFullWidth(*it); + return false; } const std::vector Terminal::GetOverlays() const noexcept