diff --git a/src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp b/src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp index 69cca9720bc8..c6b5a52a7d17 100644 --- a/src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp +++ b/src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp @@ -367,8 +367,6 @@ void CascadiaSettings::_LoadDynamicProfiles() auto profiles = generator->GenerateProfiles(); for (auto& profile : profiles) { - // If the profile did not have a GUID when it was generated, - // we'll synthesize a GUID for it in _ValidateProfilesHaveGuid profile.Source(generatorNamespace); _allProfiles.Append(profile); diff --git a/src/cascadia/ut_app/DynamicProfileTests.cpp b/src/cascadia/ut_app/DynamicProfileTests.cpp index 3dee27857144..9fc78cca902c 100644 --- a/src/cascadia/ut_app/DynamicProfileTests.cpp +++ b/src/cascadia/ut_app/DynamicProfileTests.cpp @@ -110,8 +110,7 @@ namespace TerminalAppUnitTests void DynamicProfileTests::TestGenGuidsForProfiles() { - // We'll generate GUIDs during - // CascadiaSettings::_ValidateProfilesHaveGuid. We should make sure that + // We'll generate GUIDs in the Profile::Guid getter. We should make sure that // the GUID generated for a dynamic profile (with a source) is different // than that of a profile without a source. @@ -167,8 +166,6 @@ namespace TerminalAppUnitTests VERIFY_IS_FALSE(settings->_profiles.GetAt(4).HasGuid()); VERIFY_IS_FALSE(settings->_profiles.GetAt(4).Source().empty()); - settings->_ValidateProfilesHaveGuid(); - VERIFY_IS_TRUE(settings->_profiles.GetAt(0).HasGuid()); VERIFY_IS_TRUE(settings->_profiles.GetAt(1).HasGuid()); VERIFY_IS_TRUE(settings->_profiles.GetAt(2).HasGuid()); diff --git a/src/cascadia/ut_app/JsonTests.cpp b/src/cascadia/ut_app/JsonTests.cpp index c3d240f11c4a..9111893b5adf 100644 --- a/src/cascadia/ut_app/JsonTests.cpp +++ b/src/cascadia/ut_app/JsonTests.cpp @@ -120,7 +120,7 @@ namespace TerminalAppUnitTests { // Parse some profiles without guids. We should NOT generate new guids // for them. If a profile doesn't have a GUID, we'll leave its _guid - // set to nullopt. CascadiaSettings::_ValidateProfilesHaveGuid will + // set to nullopt. The Profile::Guid() getter will // ensure all profiles have a GUID that's actually set. // The null guid _is_ a valid guid, so we won't re-generate that // guid. null is _not_ a valid guid, so we'll leave that nullopt