Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons for colour scheme in Command Palette #10131

Closed
DakshKK opened this issue May 19, 2021 · 4 comments
Closed

Icons for colour scheme in Command Palette #10131

DakshKK opened this issue May 19, 2021 · 4 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@DakshKK
Copy link

DakshKK commented May 19, 2021

Description of the new feature/enhancement

Adding icons to the iterable Select colour scheme option in command palette, or to colour schemes in general.

It could be used to provide a preview of the colour scheme in a small icon/image, since like for me, I had no idea what colours the colour scheme may have, and had to select through all of them, to see which one I liked.

So maybe adding an icon could help the person (a really stupid thought on my part), like for me I re-wrote the command, as a nested command in my settings.json, with generated colour palettes icons, since I couldn't find a way to add icons for every command in an iterable command.

The colour schemes could have an icon option, just like profiles which are referenced in iterable commands, or we can add an option to let the icon property accept an array which would set the icon for respective commands, in iterable / nested commands.
@DakshKK DakshKK added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 19, 2021
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 19, 2021
@zadjii-msft
Copy link
Member

zadjii-msft commented May 19, 2021 •
edited
Loading

Would it possibly be better if the color schemes were previewable as you went through the list in the Command Palette?

preview-set-color-scheme

(from #9794)

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label May 19, 2021
@DakshKK
Copy link
Author

DakshKK commented May 19, 2021

This would be even better, I did not think of this.

If this is already in the works, that's superb, and if it has been implemented, could someone please guide me around this.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels May 19, 2021
@mdtauk
Copy link

mdtauk commented May 19, 2021

This would be even better, I did not think of this.

If this is already in the works, that's superb, and if it has been implemented, could someone please guide me around this.

Also isn't there a preview being added to the Settings UI?

@zadjii-msft
Copy link
Member

It'll be in 1.9 ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mdtauk @zadjii-msft @DakshKK