Cannot set SetConsoleCtrlHandler

[blacklightpy]

Windows Terminal version (or Windows build number)

1.9.1523.0

Other Software

I wrote a console application in C++ and wanted to handle CTRL_CLOSE_EVENT.
I set my default terminal as Windows Terminal, so the app launched in it by default.
I wasn't sure why the method wasn't working and after a while I decided to try out running the program in conhost and it worked.

Here's the code:

BOOL WINAPI CtrlHandler(DWORD fdwCtrlType)
{
    switch (fdwCtrlType)
    {
    case CTRL_C_EVENT:
        printf("Ctrl-C event\n\n");
        Beep(750, 300);
        return TRUE;

    case CTRL_CLOSE_EVENT:
        Beep(600, 200);
        printf("Ctrl-Close event\n\n");
        return TRUE;

    case CTRL_BREAK_EVENT:
        Beep(900, 200);
        printf("Ctrl-Break event\n\n");
        return FALSE;

    case CTRL_LOGOFF_EVENT:
        Beep(1000, 200);
        printf("Ctrl-Logoff event\n\n");
        return FALSE;

    case CTRL_SHUTDOWN_EVENT:
        Beep(750, 500);
        printf("Ctrl-Shutdown event\n\n");
        return FALSE;

    default:
        return FALSE;
    }
}
int main()
{
    SetConsoleCtrlHandler((CtrlHandler, TRUE);
    while(1)
    {
        std::cin.get();
    }
}

I guessed this could be because Windows Terminal uses Win32 windows, but this could cause compatibility issues with existing console apps.

Steps to reproduce

Run the program and try to trigger a CTRL_C_EVENT

Expected Behavior

CtrlHandler handles the event

Actual Behavior

CtrlHandler is not invoked

[miniksa]

Very high chance this is resolved with #10415

[DHowett]

@blacklightpy Would you mind testing on Windows 22000.65 or higher with Windows Terminal Preview 1.10?

[ghost]

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

[blacklightpy]

@DHowett Sorry for the delay, I was sick for a while.
I'm now on 22000.100 and on Terminal Preview 1.10.1933.0
Still, the same result.

I noticed that I can hear a beep sound when I'm closing the window, meaning CTRL_CLOSE_EVENT is triggered.
But CTRL_C_EVENT and CTRL_BREAK_EVENT are still not triggered in the terminal. I didn't try the logoff and shutdown events.

The beep sound wasn't working the last time, but it wasn't working in conhost too then. Now it's working on both.

CTRL_CLOSE_EVENT too is working differently from what's expected. In conhost, the program exists only after the beep is performed. In Terminal however, the tab is close immediately and the beep is heard afterwards. So if there are any print statements in the control handler, they won't be seen. I tried setting 2 beeps and a print statement between them, and both beeps were still executed.

[miniksa]

I'll look into this when I get a chance.

[miniksa]

Okay. So far...

CTRL_BREAK_EVENT is coming in as a break if started within the Terminal, but as a CTRL_C if started from DefApp. So that one is DefApp related.

CTRL_CLOSE_EVENT seems to behave the same for both and makes the noise after the tab goes away. That slightly tracks with how tab handing works and we'd likely have to introduce a delay/ordering of sorts there to stop that one and is likely NOT DefApp related.

CTRL_C_EVENT just works in both.

Now trying to figure out how to do CTRL_LOGOFF_EVENT and CTRL_SHUTDOWN_EVENT as I think those are weird/difficult.

[miniksa]

There's another issue with CTRL_CLOSE_EVENT related to CloseTest.exe (from our tools folder). It is not propagating to all the children...