Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIA: more intelligent word boundaries #11313

Open
codeofdusk opened this issue Sep 23, 2021 · 2 comments
Open

UIA: more intelligent word boundaries #11313

codeofdusk opened this issue Sep 23, 2021 · 2 comments
Labels
Area-Accessibility Issues related to accessibility Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Conhost For issues in the Console codebase
Milestone

Comments

@codeofdusk
Copy link
Contributor

Windows Terminal version (or Windows build number)

OpenConsole commit 5deb332

Other Software

NVDA 2021.3

Steps to reproduce

Move by word in a UIA console containing the following text:

Loading file c:\test.json

Expected Behavior

In Microsoft Word, NVDA splits the word boundaries as follows:

['Loading ', 'file ', 'c', ':\\', 'test', '.', 'json']

Actual Behavior

In conhost, NVDA splits the words as follows:

['Loading ', 'file ', 'c:\\test.json                                                                                               \r\n                                                                                                                        ']
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 23, 2021
@codeofdusk
Copy link
Contributor Author

NVDA's legacy console support (and the version I implemented for pre #4018 builds) uses the Uniscribe API to determinbe word boundaries. This sort of approach, if possible in conhost, would have two benefits:

Otherwise, the word navigation in this commit is flawless (very fast and otherwise accurate). Great work @carlos-zamora!

@zadjii-msft zadjii-msft added Area-Accessibility Issues related to accessibility Product-Conhost For issues in the Console codebase labels Sep 27, 2021
@zadjii-msft
Copy link
Member

IIRC we're using the wordDelimiters for splitting words, which are configurable by the user, even in conhost (though, much harder to set for conhost). I could be wrong about that though.

The "actual behavior" here though does sound wrong 😨

@zadjii-msft zadjii-msft added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Sep 27, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 27, 2021
@carlos-zamora carlos-zamora added this to the Backlog milestone Jul 5, 2023
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Issues related to accessibility Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Conhost For issues in the Console codebase
Projects
None yet
Development

No branches or pull requests

3 participants