Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We broke \\wsl$ paths with osc 9;9? #12085

Closed
zadjii-msft opened this issue Jan 3, 2022 · 8 comments
Closed

We broke \\wsl$ paths with osc 9;9? #12085

zadjii-msft opened this issue Jan 3, 2022 · 8 comments
Labels
Area-TerminalConnection Issues pertaining to the terminal<->backend connection interface Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-1 A description (P1) Product-Terminal The new Windows Terminal. zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes.
Milestone
Terminal v1.13

Comments

@zadjii-msft
Copy link
Member

zadjii-msft commented Jan 3, 2022 •
edited
Loading

this change makes osc 9;9 work with linux paths but breaks \\wsl$ ones
docs at https://docs.microsoft.com/windows/terminal/tutorials/new-tab-same-directory will need to be updated

Originally posted by @LuanVSO in #9223 (comment)
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 3, 2022
@zadjii-msft zadjii-msft added this to the Terminal v1.13 milestone Jan 3, 2022
@zadjii-msft zadjii-msft added Area-TerminalConnection Issues pertaining to the terminal<->backend connection interface Product-Terminal The new Windows Terminal. zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) labels Jan 3, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 3, 2022
@LuanVSO
Copy link
Contributor

LuanVSO commented Jan 3, 2022

The new behavior is kind of better because it accepts untranslated Linux paths, you just need to remove the call to wslpath from the script to make it work again

@DHowett
Copy link
Member

DHowett commented Jan 3, 2022

FWIW, launching WSL with \\wsl$ itself does not have an issue. I can't see how #9223 broke it, unless for some reason the OSC 9;9 it generates is using / instead of \. That's going to burn some folks, but not nearly as many as the other behavior did!

image

@DHowett
Copy link
Member

DHowett commented Jan 3, 2022

image

Another victim of our path absoluting code.

@LuanVSO
Copy link
Contributor

LuanVSO commented Jan 4, 2022

oh, so it's already fixed by #12050

@DHowett
Copy link
Member

DHowett commented Jan 4, 2022

I'm not sure actually- didn't that only fix instances where the directory was one character long?

@LuanVSO
Copy link
Contributor

LuanVSO commented Jan 4, 2022

i tested it on my build of terminal from that branch and it worked fine.
image
image

tested with a windows path too.
got any more whacky path to test?

@DHowett
Copy link
Member

DHowett commented Jan 4, 2022

Naw, this looks great! Thanks!

@zadjii-msft
Copy link
Member Author

Thanks for fixing that for us! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-TerminalConnection Issues pertaining to the terminal<->backend connection interface Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-1 A description (P1) Product-Terminal The new Windows Terminal. zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes.
Projects
None yet
Milestone
Terminal v1.13
Development

No branches or pull requests
3 participants
@DHowett @zadjii-msft @LuanVSO