Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bellSound to the Settings UI #12103

Open
zadjii-msft opened this issue Jan 6, 2022 · 1 comment
Open

Add bellSound to the Settings UI #12103

zadjii-msft opened this issue Jan 6, 2022 · 1 comment
Labels
Area-Settings UI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone

Comments

@zadjii-msft
Copy link
Member

It's a little tricky since it can accept a single path or an array of paths. I suppose the crawl/walk/run is:

  • crawl: add a single path selector for bellSound
  • walk: Enable adding multiple paths for bellSound
  • run: add a little button next to the file picker to play a preview of that sound

as added in #11511

@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Product-Terminal The new Windows Terminal. Priority-3 A description (P3) Area-Settings UI Anything specific to the SUI labels Jan 6, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Jan 6, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 6, 2022
@zadjii-msft zadjii-msft added the Issue-Task It's a feature request, but it doesn't really need a major design. label Jan 6, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 6, 2022
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 26, 2022
@spudpiggy
Copy link

Bump, I'd rather use another sound since the default makes me think something's thrown an error because I'm so used to windows 10 and its sounds. But it's not on the ui so i have to manually edit my config, which kinda sucks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings UI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants