Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accented characters take up extra space #12940

Closed
DoubleStrike opened this issue Apr 19, 2022 · 2 comments
Closed

Accented characters take up extra space #12940

DoubleStrike opened this issue Apr 19, 2022 · 2 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@DoubleStrike
Copy link

DoubleStrike commented Apr 19, 2022

Windows Terminal version

1.13.10983.0

Windows build number

10.0.19044.0

Other Software

No response

Steps to reproduce

Show an accented character in the window, either in Command Prompt or Powershell. The character takes extra space.

This occurs both with and without Experimental Text Rendering turned on.

Expected Behavior

The character should only take a single column.

Actual Behavior

The character is centered across two columns with empty space on each side.

Here is an example from a git log pull from the Blender repository. You can see Clément's name gets screwed up:

Experimental Rendering on:
Bug-ExperimentalRenderingOn

Experimental Rendering off:
Bug-ExperimentalRenderingOff

Note that git is outputting these by using a punctuation character suffixed to the letter. In good old CMD.EXE, it looks like this:
Bug-Cmd

@DoubleStrike DoubleStrike added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Apr 19, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 19, 2022
@DHowett
Copy link
Member

DHowett commented Apr 19, 2022

Right, so this is one of the things that's part of #8000 / #1472. There are two characters there, and they are therefore afforded two cells 😄

Once we land something a little smarter for the text buffer, we'll be able to do something about that.

One of the critical issues here is determining the application's intent. For better or worse, the Windows console allows you to read back the screen contents. If we combine those into one cell, the application's measurements could be all wrong, or it could fail to read back the data that it wrote (should it so choose.) It's delicate.

/dup #8000

@ghost
Copy link

ghost commented Apr 19, 2022

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Apr 19, 2022
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 19, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants