Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow terminal restoring #13771

Open
Trard opened this issue Aug 18, 2022 · 1 comment
Open

Slow terminal restoring #13771

Trard opened this issue Aug 18, 2022 · 1 comment
Assignees
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone

Comments

@Trard
Copy link

Trard commented Aug 18, 2022

Windows Terminal version

1.14.2281.0

Windows build number

10.0.19044.0

Other Software

No response

Steps to reproduce

  1. Open and minimize windows terminal.
  2. Restore window.
  3. See slow restoring.
terminal.mp4

Expected Behavior

Quick restoring, like Microsoft Store.

msstore.mp4

or Firefox

firefox.mp4

Actual Behavior

Slow restoring

@Trard Trard added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Aug 18, 2022
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 18, 2022
@Trard Trard changed the title Slow terminal opening Slow terminal restoring Aug 18, 2022
@zadjii-msft
Copy link
Member

I know 85% what's causing this.

This is fallout from the fix to #13589, more or less.

For whatever reason, the taskbar is restoring the hidden tool window ("pseudowindow") that's attached to the Terminal, rather than the actual Terminal window. Before we fixed #13589, the Terminal just wouldn't restore from the taskbar at all. Instead, we now can determine that the tool window got restored, and we send a signal to the Terminal to cause it to get restored as well. HOWEVER, we need to debounce these requests for various reasons. So there's a 200ms throttling that happens, which delays the restore (but also prevents CRAZY FLASHING) of the terminal window.

This is all fixed in Windows 11 (there, the taskbar just restores the Terminal's main HWND).

There's also #13388 and #13640 which are tracking additional weird bugs about this scenario. Considering we need to still figure out these last Windows 10 issues, I'm considering rolling them all into one thread.

@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Priority-3 A description (P3) Area-Windowing Window frame, quake mode, tearout labels Aug 18, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 18, 2022
@zadjii-msft zadjii-msft added this to the Terminal v1.16 milestone Aug 18, 2022
@zadjii-msft zadjii-msft self-assigned this Aug 22, 2022
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 27, 2022
@lhecker lhecker added the Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. label Apr 12, 2023
@zadjii-msft zadjii-msft modified the milestones: Terminal v1.20, Backlog Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants