Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Width of kana are wrong and not uniform in Atlas #14117

Closed
PhMajerus opened this issue Oct 2, 2022 · 0 comments · Fixed by #14959
Closed

Width of kana are wrong and not uniform in Atlas #14117

PhMajerus opened this issue Oct 2, 2022 · 0 comments · Fixed by #14959
Assignees
Labels
Area-AtlasEngine In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.

Comments

@PhMajerus
Copy link

PhMajerus commented Oct 2, 2022

Windows Terminal version

1.16.2642.0

Windows build number

10.0.22621.608

Other Software

No response

Steps to reproduce

Output Japanese hiragana and katakana using any CUI software.

Hiragana test string : *かきくけこ*がぎぐげご*さしすせそ*ざじずぜぞ*たちつてと*だぢづでど*はひふへほ*ばびぶべぼ*ぱぴぷぺぽ*
In JSON : "*\u304b\u304d\u304f\u3051\u3053*\u304c\u304e\u3050\u3052\u3054*\u3055\u3057\u3059\u305b\u305d*\u3056\u3058\u305a\u305c\u305e*\u305f\u3061\u3064\u3066\u3068*\u3060\u3062\u3065\u3067\u3069*\u306f\u3072\u3075\u3078\u307b*\u3070\u3073\u3076\u3079\u307c*\u3071\u3074\u3077\u307a\u307d*"

Katakana test string : *カキクケコ*ガギグゲゴ*サシスセソ*ザジズゼゾ*タチツテト*ダヂヅデド*ハヒフヘホ*バビブベボ*パピプペポ*
In JSON : "*\u30ab\u30ad\u30af\u30b1\u30b3*\u30ac\u30ae\u30b0\u30b2\u30b4*\u30b5\u30b7\u30b9\u30bb\u30bd*\u30b6\u30b8\u30ba\u30bc\u30be*\u30bf\u30c1\u30c4\u30c6\u30c8*\u30c0\u30c2\u30c5\u30c7\u30c9*\u30cf\u30d2\u30d5\u30d8\u30db*\u30d0\u30d3\u30d6\u30d9\u30dc*\u30d1\u30d4\u30d7\u30da\u30dd*"

(Note those test strings do not include all kanas, but only those that have common (han)dakuten variants)

Expected Behavior

These characters should render as double cells (except the separating *s), with their glyphs centered.

See the result in gnome-terminal:
image

Actual Behavior

Instead, all characters are left-aligned in their cells, and several (han)dakuten, but not all, are sized smaller than two cells, but still wider than a single cell... they look more like 1.5 cells but the length of the run of characters still accounts for double cells.

Here is the result of the same output in Windows Terminal 1.16.2642.0 using Atlas Engine
image

These are precomposed characters, their decomposed versions make the wrong spacing even more extreme.

Note that this is a bug introduced by the Atlas Engine, as in the same version of Windows Terminal but with Atlas Engine disabled, the result looks fine:
image

@PhMajerus PhMajerus added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 2, 2022
@lhecker lhecker self-assigned this Oct 3, 2022
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 5, 2022
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Oct 5, 2022
@carlos-zamora carlos-zamora added this to the Terminal v1.18 milestone Oct 5, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 5, 2022
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-AtlasEngine In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants