Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal blinks once when getting focus with AtlasEngine on #15248

Closed
Avi0 opened this issue Apr 27, 2023 · 2 comments
Closed

Terminal blinks once when getting focus with AtlasEngine on #15248

Avi0 opened this issue Apr 27, 2023 · 2 comments
Labels
Area-AtlasEngine Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@Avi0
Copy link

Avi0 commented Apr 27, 2023

Windows Terminal version

1.16.10262.0

Windows build number

10.0.22621.1555

Other Software

No response

Steps to reproduce

  1. Enable AtlasEngine.
  2. Open a terminal tab.
  3. Do something away from this tab for a while (in other tabs or not in Terminal).
  4. Focus the tab opened in step 2.

It's not clear exactly what needs to be done in step 3. Maybe actively do something with a system, maybe just wait. In practice, when I'm focusing a tab after it's been idle for an hour or two, it blinks when getting focus.

Expected Behavior

Terminal does not blink.

Actual Behavior

Terminal blinks once (maybe it redraws everything)?
@Avi0 Avi0 added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 27, 2023
@lhecker
Copy link
Member

lhecker commented Apr 27, 2023

Can you try to run any elevated (admin) application in step 3? Like, let's say, open regedit from the start menu? I'm pretty sure it'll "blink" afterwards.

Generally speaking, however I'm pretty sure that I know what you're talking about, and that issue got fixed in #14959 and so I'll close this issue for now. 🙂
This line fixes it:

terminal/src/renderer/atlas/AtlasEngine.r.cpp

Line 147 in 4d5962e

if (memcmp(&_p.dxgi.adapterLuid, &desc.AdapterLuid, sizeof(LUID)) != 0)

@lhecker lhecker closed this as completed Apr 27, 2023
@lhecker lhecker added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Product-Terminal The new Windows Terminal. Area-AtlasEngine and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 27, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Apr 27, 2023
@Avi0
Copy link
Author

Avi0 commented Apr 27, 2023

@lhecker, yes, it does blink after opening any elevated application. Thanks for the explanation and for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-AtlasEngine Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lhecker @Avi0