Trouble disabling SC_CLOSE for terminal's window

[bzm3r]

Windows Terminal version

1.17.11461.0

Windows build number

10.0.19044.0

Other Software

PowerShell 7+

Steps to reproduce

I would like to disable the close (from the ALT+Space floating menu and the top-left window's "X") button for the terminal that my PowerShell session is loaded in. So, I run the following function (based on this SO answer and this blog post):

function Disable-ThisTerminalClose {
    #Calling user32.dll methods for Windows and Menus
    $MethodsCall = '
[DllImport("user32.dll")] public static extern long GetSystemMenu(IntPtr hWnd, bool bRevert);
[DllImport("user32.dll")] public static extern bool EnableMenuItem(long hMenuItem, long wIDEnableItem, long wEnable);
[DllImport("user32.dll")] public static extern long SetWindowLongPtr(long hWnd, long nIndex, long dwNewLong);
[DllImport("user32.dll")] public static extern bool EnableWindow(long hWnd, int bEnable);
'
 
    #Create a new namespace for the Methods to be able to call them
    Add-Type -MemberDefinition $MethodsCall -name NativeMethods -namespace Win32
 
    Write-Host "Added NativeMethods type..."

    #WM_SYSCOMMAND Message
    $MF_GRAYED = 0x00000001L    #Indicates that the menu item is disabled and grayed so that it cannot be selected.    
    $MF_DISABLED = 0x00000002L #Indicates that the menu item is disabled, but not grayed, so it cannot be selected.
    $MF_ENABLED = 0x00000000L #Indicates that the menu item is enabled and restored from a grayed state so that it can be selected.
    #... http://msdn.microsoft.com/en-us/library/windows/desktop/ms647636(v=vs.85).aspx
 
    $SC_CLOSE = 0xF060
    #... http://msdn.microsoft.com/en-us/library/windows/desktop/ms646360(v=vs.85).aspx

 
    #Get window handle of this Powershell process (should be the Windows Terminal?)
    $PSWindow = Get-Process | Where-Object { $_.Name -like "*Terminal*" }
    Write-Host ("Found PSWindow: " + $PSWindow)
    $hwnd = $PSWindow.MainWindowHandle
    Write-Host ("hwnd: " + $hwnd)
 
    #Get System menu of windows handled
    $hMenu = [Win32.NativeMethods]::GetSystemMenu($hwnd, 0)
 
    # #Window Style : TOOLWINDOW
    # [Win32.NativeMethods]::SetWindowLongPtr($hwnd, $GWL_EXSTYLE, $WS_EX_TOOLWINDOW) | Out-Null
 
    #Disable X Button and window itself
    Write-Host "About to disable close functionality..."
    [Win32.NativeMethods]::EnableMenuItem($hMenu, $SC_CLOSE, ($MF_GRAYED + $MF_DISABLED))
 
    Write-Host "Disabled!" -ForegroundColor Red
}

Run this function (or, paste it's body into a PowerShell 7+ session.

Expected Behavior

I was hoping that the close button (both X and in floating menu) would be disabled.

Actual Behavior

Close/X are not disabled.

[lhecker]

Why would you like to disable the close button?

[zadjii-msft]

Yea, messing with Terminal's HWND is 100% not supported.

Focus mode might be something that interests you, though, that'll entirely hide the titlebar (including the tabs).

We could theoretically make this a window theme setting. You can already hide the close button on the tabs, so there's probably room for configuring the close button too. Something ala: #12632 (comment)

[bzm3r]

Why would you like to disable the close button?

I need to trigger some cleanup scripts on exit, but PowerShell.Exiting still does not trigger correctly for when the user presses the X button. At this point, the issue has been open for so long, that I am not sure what is going on there: PowerShell/PowerShell#8000

So, I thought I'd just try to disable the X button.

We could theoretically make this a window theme setting. You can already hide the close button on the tabs, so there's probably room for configuring the close button too. Something ala: #12632 (comment)

@zadjii-msft That would be super helpful, actually. I realize that it wouldn't disable Close in the alt+Space menu, but that would still be a major improvement. Of course, the best solution is if PowerShell.Exiting just finally worked correctly...

[zadjii-msft]

Hokay, so we talked a bit with @SteveL-MSFT about this. He's gonna take another shot at PowerShell/PowerShell#8000. Because honestly, that's the right solution here. Just fix that. Not disable the close button for the Terminal. That seems like it's an unnecessarily big hammer for a weird edge case in the shell scripting engine 😅

/dup PowerShell/PowerShell#8000

[microsoft-github-policy-service]

Hi! We've identified this issue as a duplicate of one that exists on somebody else's Issue Tracker. Please make sure you subscribe to the referenced external issue for future updates. Thanks for your report!