Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode char 0x2597 (Quadrant lower right) et al. are not displayed correctly #16436

Closed
marcIhm opened this issue Dec 7, 2023 · 5 comments
Closed
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@marcIhm
Copy link

marcIhm commented Dec 7, 2023

Windows Terminal version

1.18.3181.0

Windows build number

10.0.22635.2841

Other Software

WSL2

Steps to reproduce

printf "\u2597\n" # within wsl2

Expected Behavior

The output should display a glyph with the lower right quadrant filled; just as shown in windows font selection (see screenshot).
Screenshot 2023-12-07 074953

Actual Behavior

There is only a thin vertical line (1 pixel wide ?) in the lower right quadrant; most of the rest is unfilled.
Screenshot 2023-12-07 073806

Some additional information:

  • The behaviour above does not depend on the font chosen for wsl2 (ubuntu); in my case "Ubuntu Mono"; but it looks the same for "Lucida Console"
  • The same glyph looks good in font "Segoe UI Symbol" (checked in: Windows Settings -> Fonts, see first screenshot)
  • Other Unicode Block Characters are affected in a similar way
  • This used to work two weeks ago (wsl2)
  • In the meantime, some Windows-Updates happened and I played around with "chafa" (https://github.com/hpjansson/chafa) under wsl2; I assume that such a program should not be able to corrupt the glyph handling within "Windows Terminal" ...
  • Background: The output of "figlet -f smblock 12345" within wsl2 looks ugly as a result of this issue (to try, you will need to install figlet first via "sudo apt install figlet toilet")
  • Background: No such Problems (of course) when I boot Ubuntu directly and try the same in Gnome Terminal
@marcIhm marcIhm added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Dec 7, 2023

This comment was marked as outdated.

@DHowett
Copy link
Member

DHowett commented Dec 7, 2023

Are you, by chance, using the "new text rendering engine"? It's in Settings > Rendering. After you toggle it and save, you'll need to open a new tab or pane.

@DHowett DHowett added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Dec 7, 2023
@237dmitry
Copy link

Maybe this is font problem?

Screenshot 2023-12-07 101558

@lhecker
Copy link
Member

lhecker commented Dec 7, 2023

It is possible that this hasn't ever worked correctly in AtlasEngine. The fallback for "▗" comes from Segoe UI Symbol by default (as you've already shown), which doesn't have the same aspect ratio as your chosen font. Due to that the right half of it simply gets clipped off, which is something we currently do intentionally because of this (click play in the top right): #15343 (comment)

#5897 would help a lot with this issue.

@marcIhm
Copy link
Author

marcIhm commented Dec 7, 2023

For my case the problem lies in the "new text rendering engine". If I switch it off, everything is Okay again (at least for my concerns). See:

Screenshot 2023-12-07 213159

But interestingly this is only true for my favorite font "Lucida Console".
For other fonts (e.g. "Cascadia Code") things are a tiny bit more rough:

Screenshot 2023-12-07 213431

So I agree with lhecker: It does not work perfectly with AtlasEngine either, except from the "Lucida Console"-case (and maybe others), which fortunately applies to me :- )

So, yes, I agree, that #5897 would help a lot, as for example the GnomeTerminal does a very good job on this.
Therefore I hope, that you can fix #5897 before you remove the AtlasEngine.

Thanx a lot for your help !
I am closing this now, because (as you have shown to me), there are other relevant issues which describe the same problem already ...

P.s.: I cannot find this monofur font with "block chars", for that matter. Only some cropped (?) versions without block chars ...

@marcIhm marcIhm closed this as completed Dec 7, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

4 participants