Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor accessibility providers into better separated model #2120

Closed
carlos-zamora opened this issue Jul 26, 2019 · 1 comment · Fixed by #2414
Closed

Refactor accessibility providers into better separated model #2120

carlos-zamora opened this issue Jul 26, 2019 · 1 comment · Fixed by #2414
Assignees
@carlos-zamora
Labels
Area-Accessibility Issues related to accessibility Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Conhost For issues in the Console codebase Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal 1908.1

Comments

@carlos-zamora
Copy link
Member

Description of the new feature/enhancement

ScreenInfoUiaProvider and UiaTextRange are in a shared namespace now. PR #2083 did a bit of hacking to get them to work in Windows Terminal. One big example of this is making the HWND optional.

The CORRECT approach should be to do some kind of inheritance model where the ConHost accessibility model uses an HWND and the Windows Terminal accessibility model uses its new method.

For the HWND issue specifically, it might be worth doing this alongside #2103
@carlos-zamora carlos-zamora added Product-Conhost For issues in the Console codebase Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. labels Jul 26, 2019
@carlos-zamora carlos-zamora self-assigned this Jul 26, 2019
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 26, 2019
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 26, 2019
@carlos-zamora
Copy link
Member Author

carlos-zamora commented Jul 26, 2019 •
edited
Loading

Another one:
WindowUiaProviderBase pUiaParent shouldn't be nullable in ScreenInfoUiaProvider

Use THROW_HR_IF_NULL(E_INVALIDARG, pUiaParent))

@carlos-zamora carlos-zamora mentioned this issue Jul 26, 2019
Merged
@carlos-zamora carlos-zamora added this to the August Releases milestone Jul 31, 2019
This was referenced Aug 8, 2019
Closed
Merged
@ghost ghost added the In-PR This issue has a related PR label Aug 12, 2019
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-Accessibility Issues related to accessibility Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Conhost For issues in the Console codebase Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal 1908.1
Development

Successfully merging a pull request may close this issue.

Accessibility: Refactor Providers microsoft/terminal
1 participant
@carlos-zamora