Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on closing tab running powershell in CMD #2394

Closed
legowerewolf opened this issue Aug 11, 2019 · 9 comments
Closed

Crash on closing tab running powershell in CMD #2394

legowerewolf opened this issue Aug 11, 2019 · 9 comments
Labels
Area-TerminalConnection Issues pertaining to the terminal<->backend connection interface Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely. Severity-Crash Crashes are real bad news.
Milestone
Terminal v1.0

Comments

@legowerewolf
Copy link

Feedback Hub link: https://aka.ms/AA5svj0

Environment

Windows build number: [10.0.18362.239]
Windows Terminal version (if applicable): 0.3.2171.0

Any other software? 
* Powershell 5.1.18362.145

Steps to reproduce

  1. Create a new cmd.exe tab.
  2. Use command 'powershell'.
  3. Close the tab.

Expected behavior

The tab should close with no problems.

Actual behavior

Terminal crashes, bringing all other tabs with it.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 11, 2019
@richardszalay
Copy link
Contributor

I think this might be a duplicate of #2248

@legowerewolf
Copy link
Author

@richardszalay - I don't think so. This has nothing to do with how fast you do it, and I'm pretty sure it has to do with nesting terminals.

@ghost
Copy link

ghost commented Aug 12, 2019

Hi there!

Can you please send us feedback with the Feedback Hub with this issue and paste the link here so we can more easily find your crash information on the back end?

Thanks!

image image

@ghost ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Feedback-Hub labels Aug 12, 2019
@legowerewolf
Copy link
Author

The link's there in the initial issue. I did read the template.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Aug 12, 2019
@DHowett-MSFT
Copy link
Contributor

Thanks. Sorry I missed it.

@DHowett-MSFT DHowett-MSFT added Area-TerminalConnection Issues pertaining to the terminal<->backend connection interface Product-Terminal The new Windows Terminal. Issue-Bug It either shouldn't be doing this or needs an investigation. Severity-Crash Crashes are real bad news. and removed Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 19, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 19, 2019
@DHowett-MSFT
Copy link
Contributor

It looks like we're deadlocking tearing down the connection (MSFT:22984264). Thanks!

@DHowett-MSFT DHowett-MSFT added this to the Terminal v1.0 milestone Aug 19, 2019
@zadjii-msft zadjii-msft mentioned this issue Aug 19, 2019
Closed
@zadjii-msft
Copy link
Member

This might be #1810 which is fixed by #2525. Hopefully.

@legowerewolf
Copy link
Author

When might we see #2525 in a release?

@zadjii-msft zadjii-msft added the Priority-1 A description (P1) label Jan 22, 2020
@DHowett-MSFT
Copy link
Contributor

It doesn't look like this repros any more, and if it does there's a few other issues that have a bit more info.
Feel free to let me know if you're still hitting this.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Jan 28, 2020
@DHowett-MSFT DHowett-MSFT removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 28, 2020
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Jan 28, 2020
@DHowett-MSFT DHowett-MSFT added the Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely. label Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-TerminalConnection Issues pertaining to the terminal<->backend connection interface Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely. Severity-Crash Crashes are real bad news.
Projects
None yet
Milestone
Terminal v1.0
Development

No branches or pull requests
4 participants
@richardszalay @legowerewolf @DHowett-MSFT @zadjii-msft