Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit uses of the screen buffer/alternate buffer, or come up with a design that makes this not an issue #2742

Open
DHowett-MSFT opened this issue Sep 13, 2019 · 5 comments
Labels
Area-VT Virtual Terminal sequence support Issue-Task It's a feature request, but it doesn't really need a major design. Product-Conhost For issues in the Console codebase
Milestone

Comments

@DHowett-MSFT
Copy link
Contributor

Is this indicative of a larger problem? Should we file an outstanding work item to audit all sites of manipulating the active buffer and/or somehow change the design such that the methods cannot accidentally be called without resolving which one is the active one first?

For the latter, my proposal would be to hide all the verbage methods off the base class and implement some sort of interface that holds them that is only returned when/if someone has correctly queried for the active one first. I'd accept competing proposals, though.

Originally posted by @miniksa in #2729 (comment)

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 13, 2019
@DHowett-MSFT
Copy link
Contributor Author

This would be a great place to discuss why the alt buffer is a sidecar to the current buffer instead of a new console buffer (which is a supported scenario.) If the alt buffer were a true top-level buffer (possibly with a link to its originating buffer), every API that look up the "current buffer" would get the right one.

@DHowett-MSFT DHowett-MSFT added Area-VT Virtual Terminal sequence support Issue-Task It's a feature request, but it doesn't really need a major design. Product-Conhost For issues in the Console codebase labels Sep 13, 2019
@DHowett-MSFT DHowett-MSFT added this to the Console Backlog milestone Sep 13, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 13, 2019
@mdtauk
Copy link

mdtauk commented Sep 13, 2019

What is the performance hit, if the command buffer was stored as strings, and re-drawn when needed - as opposed to being stored in texture memory?

@DHowett-MSFT
Copy link
Contributor Author

Wha? It is. We don’t cache prerendered screen content.

@DHowett-MSFT
Copy link
Contributor Author

This isn’t related to rendering :)

@mdtauk
Copy link

mdtauk commented Sep 13, 2019

Ignore me then - I always think in UI lol

@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Sep 16, 2019
@zadjii-msft zadjii-msft modified the milestones: Console Backlog, 22H2 Jan 4, 2022
@zadjii-msft zadjii-msft modified the milestones: 22H2, Backlog Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-VT Virtual Terminal sequence support Issue-Task It's a feature request, but it doesn't really need a major design. Product-Conhost For issues in the Console codebase
Projects
None yet
Development

No branches or pull requests

3 participants