Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LocalTests were broken in #3575 #4137

Closed
zadjii-msft opened this issue Jan 7, 2020 · 0 comments · Fixed by #4143
Closed

LocalTests were broken in #3575 #4137

zadjii-msft opened this issue Jan 7, 2020 · 0 comments · Fixed by #4143
Assignees
@zadjii-msft
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@zadjii-msft
Copy link
Member

I'm not sure why this wasn't picked up by the build bot, but this test now fails for me when run locally because of the trailing comma (that's not valid JSON).

terminal/src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp

Lines 431 to 439 in 4882917

const std::string settings0String{ R"(
{
"globals": {
"alwaysShowTabs": true,
"initialCols" : 120,
"initialRows" : 30,
"rowsToScroll" : 4,
}
})" };

Originally posted by @j4james in #3575
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 7, 2020
@zadjii-msft zadjii-msft added the Product-Terminal The new Windows Terminal. label Jan 7, 2020
@zadjii-msft zadjii-msft self-assigned this Jan 7, 2020
@zadjii-msft zadjii-msft mentioned this issue Jan 7, 2020
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label Jan 7, 2020
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jan 7, 2020
@kellytrinh kellytrinh mentioned this issue Aug 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a test that regressed during #3575 microsoft/terminal
1 participant
@zadjii-msft