Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal Pane Splitting puts cursor on incorrect line #5295

Closed
spetz83 opened this issue Apr 9, 2020 · 8 comments
Closed

Horizontal Pane Splitting puts cursor on incorrect line #5295

spetz83 opened this issue Apr 9, 2020 · 8 comments
Labels
Area-VT Virtual Terminal sequence support Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely.
Milestone

Comments

@spetz83
Copy link

spetz83 commented Apr 9, 2020

Environment

Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd]
10.0.19041.0
Windows Terminal version (if applicable):
0.10.781.0
Any other software?
N/A

Steps to reproduce

  • Open Windows Terminal
  • Trigger Horizontal pane split

Expected behavior

I expect the pane to be split horizontally with the cursor on the same line as the current directory prompt similar to below screen shot.
image

Actual behavior

When you do the first horizontal pane split the cursor jumps down a line in the newly opened pane. However, if you split horizontally a second time, the second pane cursor appears correctly. See below gif.
terminal

A vertical pane split does not exhibit the same behavior.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 9, 2020
@zadjii-msft
Copy link
Member

GAH that's not great.

Could you share the config for whatever shell you're using? I'm betting that this is due to that first line that's getting printed in your prompt. Clearly the right text is in the buffer (because the third pane you create refreshes the contents of the second pane to be displayed correctly), but maybe we missed a frame or something.

I'd also bet that #5181 either made this way better or worse (see #5291).

@zadjii-msft zadjii-msft added Area-VT Virtual Terminal sequence support Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Apr 9, 2020
@zadjii-msft zadjii-msft self-assigned this Apr 9, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 9, 2020
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Apr 9, 2020
@spetz83
Copy link
Author

spetz83 commented Apr 9, 2020

So, I'm using ZSH, so do you want the zshrc file I have? I've been using the same zshrc file for quite a while, this only started happening in the last month or 2.

@spetz83
Copy link
Author

spetz83 commented Apr 9, 2020

I should clarify, ZSH using Oh My ZSH.

@spetz83
Copy link
Author

spetz83 commented Apr 9, 2020

zshrc-bak.txt

@zadjii-msft
Copy link
Member

Yikes okay, I'm not seeing this on my build with the same .zshrc, but it's entirely possible that the bits from #5181 fixed this, making it hard for me to repro. I'm pulling a 0.10 build now to check if that build will repro this.

@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 9, 2020
@zadjii-msft
Copy link
Member

Okay I unfortunately can't get this to repro on 0.10.781 either, even with the same zsh config. I'm really hoping that this is just going to go away in 0.11, but since I can't be sure, I think I'm just going to have to stick it in the 1.x milestone.

@zadjii-msft zadjii-msft removed their assignment Apr 10, 2020
@spetz83
Copy link
Author

spetz83 commented Apr 27, 2020

@zadjii-msft Wanted to let you know. I updated to 0.11.1121.0 and I can no longer replicate this issue. Everything seems to be working correctly again. Thanks for looking into this.

@spetz83 spetz83 closed this as completed Apr 27, 2020
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Apr 27, 2020
@zadjii-msft
Copy link
Member

I'm glad to hear it! Thanks for following up on this thread 😄

@zadjii-msft zadjii-msft added the Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely. label Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-VT Virtual Terminal sequence support Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely.
Projects
None yet
Development

No branches or pull requests

3 participants