Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor fire_and_forget methods in AppLogic to use weak refs #6295

Closed
jelster opened this issue Jun 1, 2020 · 1 comment
Closed

Refactor fire_and_forget methods in AppLogic to use weak refs #6295

jelster opened this issue Jun 1, 2020 · 1 comment
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Engineering Impro...

Comments

@jelster
Copy link
Contributor

jelster commented Jun 1, 2020

... AppLogic controls the lifetime of the entire application, so it's actually never going away, and we don't need to really worry about it. Though...it wouldn't hurt to do the right thing there as well.

Originally posted by @zadjii-msft in https://github.com/_render_node/MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDQzMzQyMzM1NQ==/comments/review_comment

Basically, there's a small handful of fire_and_forget methods in AppLogic that could be refactored to use the weak reference pattern mentioned in the above
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 1, 2020
@jelster jelster mentioned this issue Jun 1, 2020
Merged
5 tasks
@carlos-zamora carlos-zamora added Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 1, 2020
@carlos-zamora carlos-zamora added this to the Terminal Backlog milestone Jun 1, 2020
@zadjii-msft
Copy link
Member

Oaky well first off, github exploded that link. Right one is: #4908 (comment)

Secondly - I think we did this. I don't see any more fire_and_forgets in AppLogic OR TerminalWindow that don't anything bad with fire_and_forget anymore. Huzzah!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Engineering Improvements
Development

No branches or pull requests
3 participants
@jelster @carlos-zamora @zadjii-msft