Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move u8State from WriteConsoleAImpl to SCREEN_INFORMATION #6982

Open
german-one opened this issue Jul 20, 2020 · 1 comment
Open

Move u8State from WriteConsoleAImpl to SCREEN_INFORMATION #6982

german-one opened this issue Jul 20, 2020 · 1 comment
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Conhost For issues in the Console codebase
Milestone
Engineering Impro...

Comments

@german-one
Copy link
Contributor

Environment

Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd] 10.0.19041.388
Windows Terminal version (if applicable): 1.0.1811.0 + recent preview

In #4493 @miniksa pointed out that the state should be a member of SCREEN_INFORMATION rather than a static variable in WriteConsoleAImpl. Refer to
#4493 (comment)
In the current code base it's still in WriteConsoleAImpl though.

terminal/src/host/_stream.cpp

Line 1107 in d0ff5f6

static til::u8state u8State{};

Since I closed the PR I just don't want this information to get lost.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 20, 2020
@DHowett DHowett added Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Conhost For issues in the Console codebase labels Jul 27, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 27, 2020
@DHowett DHowett added this to the Console Backlog milestone Jul 27, 2020
@DHowett
Copy link
Member

DHowett commented Jul 27, 2020

Thanks for filing this! I'm going to mark it up for the conhost backlog.

@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 27, 2020
@KalleOlaviNiemitalo KalleOlaviNiemitalo mentioned this issue Oct 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Conhost For issues in the Console codebase
Projects
None yet
Milestone
Engineering Improvements
Development

No branches or pull requests
3 participants
@DHowett @zadjii-msft @german-one