Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Preview] Keep the Command Palette around after executing a command #7011

Closed
WSLUser opened this issue Jul 22, 2020 · 4 comments
Closed

[Preview] Keep the Command Palette around after executing a command #7011

WSLUser opened this issue Jul 22, 2020 · 4 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Won't-Fix We're just really obstinate about this. There's probably a good reason.
Milestone

Comments

@WSLUser
Copy link
Contributor

WSLUser commented Jul 22, 2020

Description of the new feature/enhancement

I tested using the Command Palette after finding how to bind it in the PR (perhaps adding an entry bound to null in defaults.json would be in order). First I enabled the AlwaysonTop Mode. Then I wanted to do another command from the Command Palette. But as soon as I enabled the AlwaysonTop Mode, the Command Palette exited. If I open it and then press ESC, it will close the Command Palette. So we have a way to exit without executing a command. Therefore from a usability point of view, please don't close it unless the user explicitly closes it using ESC (or any other bound key used for exiting). This would help someone open and close multiple tabs/panes quickly as well as enabling/disabling different visual modes quickly.

Proposed technical implementation details (optional)

Alter the method used for closing the Command Palette to require a user explicitly do so. We can add a setting to change this behavior (which I guess could also be toggable, inception anyone?) to always close after executing a command but I think not many users will want that behavior.

@WSLUser WSLUser added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jul 22, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 22, 2020
@zadjii-msft zadjii-msft added the Issue-Task It's a feature request, but it doesn't really need a major design. label Jul 23, 2020
@zadjii-msft
Copy link
Member

So the command palette was inspired heavily by the ones in VsCode and Sublime, both of which dismiss by default after executing a command. I'm open to the idea of making this a setting, but keeping the current behavior as the default.

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Jul 23, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 23, 2020
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Jul 23, 2020
@zadjii-msft zadjii-msft added good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. labels Jul 23, 2020
@DHowett
Copy link
Member

DHowett commented Jul 24, 2020

If we can find good examples of other applications that don't dismiss, I'd be glad to see them.

Most of our actions change the terminal in some way that is immediately attention-switching for the user. Not dismissing the command list would get in the user's way.

@WSLUser
Copy link
Contributor Author

WSLUser commented Jul 24, 2020

I would still prefer having an option to keep it around and closing it myself when I'm done with it. This is basically an alternative to constantly typing out wt arguments or enabling certain settings in the json file (such as retro and alwaysontop). It's not easy remembering all the argument syntax and I can't always have the page in front of me that tells me how to do it. So this provides a useful alternative to getting things how I want without messing with typing out an argument. I'd also argue it's a much faster way too for some users once the option to keep it around is available.

@DHowett
Copy link
Member

DHowett commented Jul 27, 2020

So, okay, I've thought about this over the weekend.

I'd rather reduce the need to run back-to-back commands instead of making running back-to-back commands easier.

The right way to run multiple commands back to back to get the terminal into a known state is going to be through #5970. If a user has multiple things they need to do to a specific terminal before it's usable, and they're all things that are exposed via commands or config options, that's what a profile is for.

In the future, when we have 5970, "enter fullscreen and toggle retro mode" can be a single command so you don't need to run them back-to-back.

Please feel free to continue the discussion, but for now I'm gonna mark this one rejected.

@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 27, 2020
@DHowett DHowett closed this as completed Jul 27, 2020
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Jul 27, 2020
@DHowett DHowett added the Resolution-Won't-Fix We're just really obstinate about this. There's probably a good reason. label Jul 27, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Won't-Fix We're just really obstinate about this. There's probably a good reason.
Projects
None yet
Development

No branches or pull requests

3 participants