Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow color fields to refer back to the active color scheme (like "cursorColor = yellow") #7522

Open
vefatica opened this issue Sep 3, 2020 · 7 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone

Comments

@vefatica
Copy link

vefatica commented Sep 3, 2020

I can't do this

"cursorColor": "yellow"

AFAICT, to get a "yellow" cursor I must (look up and) hard code the "yellow" value from the current theme.

Is there a better way? If not I suggest that you allow color names for "cursorColor"

And what's the difference between "#rgb" and "#rrggbb"?

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 3, 2020
@DHowett
Copy link
Member

DHowett commented Sep 3, 2020

I was sure that we had a feature request for this already, but it looks like we don't! Thanks!

The difference between #rgb and #rrggbb is that #rgb is shorter.

@DHowett DHowett changed the title cursorColor, allow color names? Allow color fields to refer back to the active color scheme (like "cursorColor = yellow") Sep 3, 2020
@DHowett DHowett added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 3, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 3, 2020
@DHowett DHowett added this to the Terminal Backlog milestone Sep 3, 2020
@DHowett
Copy link
Member

DHowett commented Sep 3, 2020

Link: #3327

@DHowett
Copy link
Member

DHowett commented Sep 3, 2020

Link: #5776

@vefatica
Copy link
Author

vefatica commented Sep 3, 2020

I searched too (but not as hard as you).

And/or ... allow an integer index in the palette, as in

"cursorColor": 3 // "yellow"

@vefatica
Copy link
Author

vefatica commented Sep 3, 2020

The difference between #rgb and #rrggbb is that #rgb is shorter.

That's obvious. :-) Is there any difference in their use? Is there any alternative to "#123456"?

@DHowett
Copy link
Member

DHowett commented Sep 3, 2020

Nah. I believe the #rgb shorthand comes from CSS, and as such is very convenient for web color grading. You specify one nybble for each color, and that nybble is copied over the one you didn't specify: #c12 becomes #cc1122 and #fff becomes #ffffff.

There's no shorthand for #123456 (nor can there ever be?) because there's no way to specify the same amount of information by specifying less information 😉

@vefatica
Copy link
Author

vefatica commented Sep 3, 2020

You specify one nybble for each color, and that nybble is copied over the one you didn't specify: #c12 becomes #cc1122 and #fff becomes #ffffff.

Thanks for the explanation. That's odd. I never saw it before.

@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants