Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: wrong mouse cursor is used when hovering over a link #8258

Closed
joukevandermaas opened this issue Nov 13, 2020 · 4 comments
Closed
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@joukevandermaas
Copy link

Environment

Windows build number:
Platform ServicePack Version      VersionString
-------- ----------- -------      -------------
 Win32NT             10.0.19041.0 Microsoft Windows NT 10.0.19041.0

Windows Terminal version (if applicable): 1.5.3142.0

Any other software?

Steps to reproduce

Hover over a URL in the terminal. A tooltip says "ctrl+click to follow link", but the mouse cursor stays the "normal select" cursor.

Expected behavior

I expect the "link select" mouse cursor to be used when hovering over links.
image

Actual behavior

This cursor is used:
image

I couldn't figure out how to take a screenshot that includes the mouse cursor, Windows hides it when pressing the print screen button. But this is the context:

image

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 13, 2020
@PhMajerus
Copy link

PhMajerus commented Nov 13, 2020

This is more about discoverability than accessibility.

The hand is typically only displayed when a click would immediately follow the link.
In MS Office apps for example, the cursor hovering a hyperlink only turns into a hand when Ctrl is held down. This makes it clear to the user that a click without Ctrl has the normal selection behavior, while a click with Ctrl down would follow the link.
Windows Terminal should follow the same behavior for clarity and discoverability, arrow cursor when hovering and hand cursor when Ctrl is down.

@joukevandermaas
Copy link
Author

Yeah perhaps accessibility is not the right word, I am not sure how to categorize the issue.

To be 100% clear, when holding ctrl, it currently does not change the mouse cursor. The solution you describe makes perfect sense to me.

@zadjii-msft
Copy link
Member

Thanks for the suggestion! This is actually already being tracked by another issue on our repo - please refer to #7563 for more discussion.

/dup #7563

@ghost
Copy link

ghost commented Nov 13, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Nov 13, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 13, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants