Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "recent commands' to Command Palette in commandline mode #8296

Closed
Don-Vito opened this issue Nov 16, 2020 · 6 comments
Closed

Add "recent commands' to Command Palette in commandline mode #8296

Don-Vito opened this issue Nov 16, 2020 · 6 comments
Assignees
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@Don-Vito
Copy link
Contributor

Description of the new feature/enhancement

The idea is to store the history of the recent commands dispatched from command palette in command line mode. This history will be presented below the search bar. Typing in the search bar will filter the relevant history items (similar to the behavior we already have with filtering commands in action mode).

image

Usually when I use command palette in the command line mode I do it to run the same commands.
This feature will save me a lot of typing and prevent typos.

Proposed technical implementation details (optional)

I am not sure what is the best place to store the history, and what are the security concerns if exist.
We can start with storing the history in memory for the current session.

@Don-Vito Don-Vito added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Nov 16, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 16, 2020
@skyline75489
Copy link
Collaborator

I like this! VSCode will show recent commands history in its command palette and I found it useful.

@zadjii-msft
Copy link
Member

dang this is a good idea

We could certainly start with work with just stashing the recently used commands in memory while a window is open, and then once #7972 is implemented, we could actually write the mru list to disk and load it from there.

I'll stick this in #5400. Thanks!

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Nov 17, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 17, 2020
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Nov 17, 2020
@Don-Vito
Copy link
Contributor Author

@zadjii-msft - then I would like to work on this 😊

@zadjii-msft
Copy link
Member

Go for it!

@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 17, 2020
@ghost ghost added the In-PR This issue has a related PR label Nov 18, 2020
@Don-Vito
Copy link
Contributor Author

Implemented in-memory, MRU list (not set) of 10 (hard-coded).
There is no auto-completion, the history entries get filtered out, however-to invoke the entry you need to select the item:
CommandHistory2

@ghost ghost removed the In-PR This issue has a related PR label Nov 25, 2020
@ghost ghost closed this as completed in 274f5a7 Nov 25, 2020
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Nov 25, 2020
@ghost
Copy link

ghost commented Jan 28, 2021

🎉This issue was addressed in #8317, which has now been successfully released as Windows Terminal Preview v1.6.10272.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests

4 participants