Add ACR service connection resource #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
beandrad
force-pushed
the
acr-service-endpoint
branch
from
6484252
to
d7a6a60
Compare
EliiseS
requested changes
Jul 31, 2020
azuredevops/internal/service/serviceendpoint/resource_serviceendpoint_azurecr.go
Outdated
Show resolved
Hide resolved
| # azure container registry service connection | ||
| resource "azuredevops_serviceendpoint_azurecr" "azurecr" { | ||
| project_id = azuredevops_project.project.id | ||
| service_endpoint_name = "Sample AzureCR" |
There was a problem hiding this comment.
Could you also format this terraform?
There was a problem hiding this comment.
I don't think this is formatted still
These have different indentation:
service_endpoint_name = "Sample AzureCR"
resource_group = "sample-rg"
349462a
to
be2f196
Compare
So that an ACR service connection resource can be defined in Terraform.
beandrad
force-pushed
the
acr-service-endpoint
branch
from
be2f196
to
92d8899
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that an ACR service connection resource can be defined in
Terraform.
All Submissions:
What about the current behavior has changed?
Added
azuredevops_serviceendpoint_azurecr, which allows to create an ACR service connection.Issue Number: #33
Does this introduce a change to
go.mod,go.sumorvendor/?Does this introduce a breaking change?
Any relevant logs, error output, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Other information