Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for approvals and other checks (service connections, environments) #451

Closed
kensykora opened this issue Sep 24, 2021 · 8 comments
Labels

Comments

@kensykora
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Please add support for approvals and checks on service connections. This would be helpful so we can audit and automate our security and release policies

image
image

This would also be applicable to ADO environments, Service Connections, etc.

New or Affected Resource(s)

  • azuredevops_approval
  • azuredevops_check_business_hours

Potential Terraform Configuration

resource "azuredevops_approval" "prod_approvers" {
  # service_connection_id or environment_id
  service_connection_id = 12345
  users = [
    azuredevops_user.break_glass.id,
    azuredevops_group.production_approvers.id
  ]
  timeout_days = 30
  allow_approve_own = false
  instructions_to_approvers = "Please approve this"
}

resource "azuredevops_check_business_hours" "business_hours" {
  # service_connection_id or environment_id
  environment_id = 3
  monday = false
  tuesday = true
  time_zone_offset = "+00:00"
  start_time = "04:00"
  end_time = "22:00"
}

See other types as well in screen shot above

@xuzhang3
Copy link
Collaborator

@kensykora This resources is supported since v6.1. Blocked by go-sdk microsoft/azure-devops-go-api#93

@rdalbuquerque
Copy link
Contributor

@xuzhang3 Apparently pipelineschecks is already available on azure-devops-go-api since microsoft/azuredevops-go-api#87. This would indeed be very helpful.

@samtarplee
Copy link

@xuzhang3 Is this still blocked? It looks like the new API version has been released and supports this now

@xuzhang3
Copy link
Collaborator

@samtarplee The approvals APIs are available in v6.1, the latest supported API by SDK is v6.0

@biscuitcakes
Copy link

@xuzhang3 Any chance there's been any progress here?

@xuzhang3
Copy link
Collaborator

@alex-charles this feature depends on the API v6.1 which is not supported by current go-SDK

@drdamour
Copy link
Contributor

drdamour commented Feb 3, 2023

guess we track this in #662 now

@xuzhang3
Copy link
Collaborator

azuredevops_check_approval supported in #728 and available in v0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants