Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new Resource Release Definition #49

Open
EliiseS opened this issue Jul 2, 2020 · 14 comments
Open

Implement new Resource Release Definition #49

EliiseS opened this issue Jul 2, 2020 · 14 comments

Comments

@EliiseS
Copy link
Member

EliiseS commented Jul 2, 2020


Migrated from #281
Originally created by @gertjvr on Sun, 26 Apr 2020 05:50:24 GMT


Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

New or Affected Resource(s)

  • azuredevops_XXXXX

Potential Terraform Configuration

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.

References

  • #0000
@EliiseS
Copy link
Member Author

EliiseS commented Jul 2, 2020


Migrated from #281 (comment)
Originally created by @nmiodice on Tue, 05 May 2020 16:27:56 GMT


If somebody from the community would like to implement this we'll absolutely take the contribution. However, I don't for-see us having the capacity to prioritize this feature based on the direction that AzDO in general is moving.

@exocom or @jonasbark would you be willing to port the changes into this provider?

@EliiseS
Copy link
Member Author

EliiseS commented Jul 2, 2020


Migrated from #281 (comment)
Originally created by @nmiodice on Tue, 05 May 2020 16:52:46 GMT


There is a WIP tag that we can use to mark it as such.

I'm OK with the large PR, or with partial functionality. This is one of the reasons I prefer YAML, btw :D

@EliiseS
Copy link
Member Author

EliiseS commented Jul 2, 2020


Migrated from #281 (comment)
Originally created by @exocom on Tue, 05 May 2020 16:46:18 GMT


@nmiodice Yes, I've got a branch I would love to get in. I've been waiting to open a PR because it still had some fundamental bugs. Most of the bugs have now been worked out and it is finally at a stable point.

One other challenge is the shear size of the API payload. This thing is massive and there are still parts that are missing because they are can be added later. So it is kinda an all or nothing problem, meaning the PR is massive and the review might get stuff in limbo for quite some time due to its size.

I wanted to add some documentation to help ease the PR process. Other than that how do we proceed? Do you have a way to mark this as WIP or can we mark it as experimental etc?

@EliiseS
Copy link
Member Author

EliiseS commented Jul 2, 2020


Migrated from #281 (comment)
Originally created by @nmiodice on Thu, 30 Apr 2020 16:22:14 GMT


Can you add some information to the issue @gertjvr? I'm not really sure what you are referring to.

If you are talking about release definitions in the sense of the ones you create using the UI, I don't think it is worthwhile to build this out because there has been a heavy investment from Microsoft in YAML based pipelines, which offer a more natural way to configure these releases and has lots of great templating features.

https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=azure-devops&tabs=schema%2Cparameter-schema

I'd recommend using that. I'll close this issue if there is no response in the next few days.

@EliiseS
Copy link
Member Author

EliiseS commented Jul 2, 2020


Migrated from #281 (comment)
Originally created by @nmiodice on Fri, 22 May 2020 17:41:19 GMT


This is awesome to see @exocom! Thanks for the contribution.

Based on the size of the implementation we may want to consider hosting this code, or a lot of the specific implementation logic, in its own package. cc @xuzhang3 - I'm interested to hear your thoughts. Perhaps its a good candidate to test out the proposal in #324 (?)

@EliiseS
Copy link
Member Author

EliiseS commented Jul 2, 2020


Migrated from #281 (comment)
Originally created by @xuzhang3 on Tue, 26 May 2020 06:23:37 GMT


This is awesome to see @exocom! Thanks for the contribution.

Based on the size of the implementation we may want to consider hosting this code, or a lot of the specific implementation logic, in its own package. cc @xuzhang3 - I'm interested to hear your thoughts. Perhaps its a good candidate to test out the proposal in #324 (?)

I think we should separate rich package and release definition into two PRs, they have different feature and different purpose.

@EliiseS
Copy link
Member Author

EliiseS commented Jul 2, 2020


Migrated from #281 (comment)
Originally created by @exocom on Fri, 22 May 2020 04:20:02 GMT


Added #333 with WIP in the title. We use the code from the PR on a daily basis and it does function, however, there are many gotchas. So next up is adding documentation so others can easily try it out.

Looking forward to making this happen with help form the community.

@EliiseS
Copy link
Member Author

EliiseS commented Jul 2, 2020


Migrated from #281 (comment)
Originally created by @gertjvr on Fri, 01 May 2020 21:49:34 GMT


while I agree that pipelines are the way forward, currently looking after a few azuredevops instances that are using releases and don't see those customer pivoting away from releases until there is official word that they are depreciated.

Would love a way to automate creating those release pipelines, alongside the ci pipeline.

@EliiseS
Copy link
Member Author

EliiseS commented Jul 2, 2020


Migrated from #281 (comment)
Originally created by @jonasbark on Sun, 03 May 2020 15:51:43 GMT


If you like to live on the very experimental side, there's a branch by @exocom regarding release definitions:
https://github.com/exocom/terraform-provider-azuredevops/tree/release-definitions

With some further adjustments and lots of workarounds I was able to make it work for us.

@EliiseS
Copy link
Member Author

EliiseS commented Jul 2, 2020

@exocom Can you comment on this issue so I can assign you back?

Context: isaacs/github#100 (comment)

@FernandoMiguel
Copy link

was there any progress on finishing this?

@xuzhang3
Copy link
Collaborator

xuzhang3 commented Mar 4, 2021

There is a draft PR on this issue #178 , not sure if @exocom still working on this.

@exocom
Copy link
Contributor

exocom commented Mar 4, 2021

@FernandoMiguel The branch is quite a bit out of date & we are looking for some help to get it up to date. I don't plan on picking it back up until June or July of this year. Let me know if you are interested in pitching in.

@azend
Copy link

azend commented May 3, 2023

Bumping this issue because releases haven't gone away and many customers still have investment in them. https://learn.microsoft.com/en-us/rest/api/azure/devops/release/?view=azure-devops-rest-7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants