[rel/3.6] Fix MSTEST0030 to correctly handle all methods (#3974)

microsoft · Oct 30, 2024 · d0b9266 · d0b9266
1 parent b170f00
commit d0b9266
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 7 deletions.
diff --git a/src/Analyzers/MSTest.Analyzers/TypeContainingTestMethodShouldBeATestClassAnalyzer.cs b/src/Analyzers/MSTest.Analyzers/TypeContainingTestMethodShouldBeATestClassAnalyzer.cs
@@ -77,7 +77,7 @@ private static void AnalyzeSymbol(SymbolAnalysisContext context, INamedTypeSymbo
 
         bool hasTestMethod = false;
         INamedTypeSymbol? currentType = namedTypeSymbol;
-        do
+        while (currentType is not null && !hasTestMethod)
         {
             foreach (ISymbol classMember in currentType.GetMembers())
             {
@@ -94,16 +94,10 @@ private static void AnalyzeSymbol(SymbolAnalysisContext context, INamedTypeSymbo
                         break;
                     }
                 }
-
-                if (!hasTestMethod)
-                {
-                    break;
-                }
             }
 
             currentType = currentType.BaseType;
         }
-        while (currentType is not null && !hasTestMethod);
 
         if (!hasTestMethod)
         {

diff --git a/...nitTests/MSTest.Analyzers.UnitTests/TypeContainingTestMethodShouldBeATestClassAnalyzer.cs b/...nitTests/MSTest.Analyzers.UnitTests/TypeContainingTestMethodShouldBeATestClassAnalyzer.cs
@@ -162,4 +162,28 @@ public void TestMethod1()
 
         await VerifyCS.VerifyAnalyzerAsync(code);
     }
+
+    public async Task WhenClassHasTestInitializeAndThenTestMethod_Diagnostic()
+    {
+        string code = """
+            using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+            public class [|TestClass|]
+            {
+                [TestInitialize]
+                public void Initialize()
+                {
+
+                }
+
+                [TestMethod]
+                public void TestMethod1()
+                {
+
+                }
+            }
+            """;
+
+        await VerifyCS.VerifyAnalyzerAsync(code);
+    }
 }