Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--diagnostic-log not sort-by-name friendly #3751

Open
AliveDevil opened this issue Sep 3, 2024 · 2 comments
Open

--diagnostic-log not sort-by-name friendly #3751

AliveDevil opened this issue Sep 3, 2024 · 2 comments
Assignees
Labels
Area: Testing Platform Belongs to the Microsoft.Testing.Platform core library Type: Feature

Comments

@AliveDevil
Copy link

AliveDevil commented Sep 3, 2024

Describe the bug

The --diagnostic-option creates files with an opaque, non-modified date sorting friendly file name.

Steps To Reproduce

  1. Run multiple successive tests with --diagnostic, when process Ids are recycled, the name sorting option is useless.

Expected behavior

Some name sorting friendly file prefix (i.e. log_yyyymmddThhmmss_ProcessId.diag).

Actual behavior

Screenshot_20240903_125137

log_09030958760.diag: 11:47
log_09031011248.diag: 12:30
log_09031028245.diag: 12:34
log_09031043246.diag: 12:17
log_09031043969.diag: 12:10
log_09031045242.diag: 12:34
log_09031055355.diag: 12:09
@nohwnd nohwnd added Type: Feature Area: Testing Platform Belongs to the Microsoft.Testing.Platform core library and removed Needs: Triage 🔍 labels Sep 3, 2024
@nohwnd nohwnd added this to the MSTest 3.7 / Platform 1.5 milestone Sep 3, 2024
@nohwnd
Copy link
Member

nohwnd commented Sep 3, 2024

Adding to next milestone, looks like low hanging fruit, and I don't think change of name in diag log should be considered a breaking change.

@MarcoRossignoli MarcoRossignoli self-assigned this Sep 5, 2024
@MarcoRossignoli
Copy link
Contributor

MarcoRossignoli commented Sep 5, 2024

? Some name sorting friendly file prefix (i.e. log_yyyymmddThhmmss_ProcessId.diag)

Fine to me a format like that, keeping in mind that you should not take the "process_id" as guarantee for nothing, that id can be reused for different processes, maybe we can simply have time ordering, anyway today we have a retry loop if the file is already taken by someone else in the same folder so the order will be preserved and the pid says nothing about the nature of the file, maybe we can add the tfm the make easy to read it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Testing Platform Belongs to the Microsoft.Testing.Platform core library Type: Feature
Projects
None yet
Development

No branches or pull requests

3 participants