Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show telemetry banner if no telemetry provider is registered #3823

Closed
MarcoRossignoli opened this issue Sep 13, 2024 · 0 comments · Fixed by #3862
Closed

Do not show telemetry banner if no telemetry provider is registered #3823

MarcoRossignoli opened this issue Sep 13, 2024 · 0 comments · Fixed by #3862
Assignees
@Evangelink
Labels
Area: Testing Platform Belongs to the Microsoft.Testing.Platform core library In-PR Type: Bug
Milestone
MSTest 3.6.1 / Pl...

Comments

@MarcoRossignoli
Copy link
Contributor

We should not show the telemetry banner if no telemetry provider is registered, this could alarm users without reason, in the sample below we don't have any telemetry provider when integrated with xunit v3 but the banner shows the same.

image
@MarcoRossignoli MarcoRossignoli added Type: Bug Area: Testing Platform Belongs to the Microsoft.Testing.Platform core library labels Sep 13, 2024
@nohwnd nohwnd changed the title Do not show telemetry banner if not telemetry provider are registered Do not show telemetry banner if no telemetry provider is registered Sep 13, 2024
@Evangelink Evangelink self-assigned this Sep 24, 2024
@Evangelink Evangelink mentioned this issue Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Evangelink Evangelink

Labels
Area: Testing Platform Belongs to the Microsoft.Testing.Platform core library In-PR Type: Bug
Projects
None yet
Milestone
MSTest 3.6.1 / Platform 1.4.1
Development

Successfully merging a pull request may close this issue.

Fix: do not show telemetry banner if no telemetry provider is registered Evangelink/testfx
2 participants
@MarcoRossignoli @Evangelink