Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for THttpClient Transport #370

Closed
cyber-gh opened this issue Jul 2, 2020 · 6 comments
Closed

Support for THttpClient Transport #370

cyber-gh opened this issue Jul 2, 2020 · 6 comments

Comments

@cyber-gh
Copy link

cyber-gh commented Jul 2, 2020

Are there any plans to support the THttpClient from the original thrift implementation?

@benjamin-bader
Copy link
Collaborator

No current plans, but that's only because we haven't had that need. I'm not opposed to it, but don't personally have the time or inclination to do the work myself. I'd be happy to help guide a PR.

@cyber-gh
Copy link
Author

cyber-gh commented Jul 5, 2020

I will give it a try, but this may take some time, as I have to document on this in topic

@clayreimann
Copy link

@benjamin-bader I'm also interested in seeing this happen (especially given the server-side thrift stuff that looks to be landing soon). Can you point me to the places that I should start looking to build the new transport?

@benjamin-bader
Copy link
Collaborator

Most transports live in https://github.com/microsoft/thrifty/tree/master/thrifty-runtime/src/commonMain/kotlin/com/microsoft/thrifty/transport.

For convenience you might start putting your code here, but I see a few issues to be resolved prior to merging:

  • this is "common" code and most HTTP libraries are platform-specific. Maybe OkHttp is multiplatform now?
  • a main goal of this project is to be as lightweight as possible in terms of method references. It may be desirable to put this transport into its own module.

@luqasn
Copy link
Contributor

luqasn commented Nov 16, 2023

I think this can be close now as it was added in #449 :)

@benjamin-bader
Copy link
Collaborator

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants