Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tmlanguage not parsing comment in template parameter correctly #3017

Closed
timotheeguerin opened this issue Mar 13, 2024 · 1 comment · Fixed by #3018
Closed

tmlanguage not parsing comment in template parameter correctly #3017

timotheeguerin opened this issue Mar 13, 2024 · 1 comment · Fixed by #3018
Assignees
@timotheeguerin
Milestone
[2024] April

Comments

@timotheeguerin
Copy link
Member 

model Test<A
// Comment
,
B // Comment
> {

}

works fine in template argument in type reference however
image
@timotheeguerin
Copy link
Member Author

timotheeguerin commented Mar 13, 2024 •
edited
Loading

Works for interface and union but not for models, scalars and operations

@timotheeguerin timotheeguerin self-assigned this Mar 13, 2024
@timotheeguerin timotheeguerin added this to the [2024] April milestone Mar 13, 2024
@timotheeguerin timotheeguerin mentioned this issue Mar 13, 2024
Merged
catalinaperalta pushed a commit to catalinaperalta/typespec that referenced this issue Mar 20, 2024
@timotheeguerin @markcowl
Samples as tests (microsoft#2215)
31fd5ab 
fix [microsoft#3017](https://github.com/Azure/typespec-azure/issues/3017)

Run the samples as test which allows all of them to run without crashing
on the first one, lets us run it in the test explorer.

This also make the sample regeneration much faster(typespec azure repo):
- Before `~90s`
- Now `~12s`


![image](https://github.com/microsoft/typespec/assets/1031227/a3356a90-7847-43cf-a473-4ecda0c53330)

## New `resolveCompilerOptions` utils
This also include the addition of a new util `resolveCompilerOptions`
that resolve the compiler options programtically in the same way that
the cli would have for a given entrypoint.

I can move this into a dedicated PR if people prefer.

---------

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
timotheeguerin added a commit that referenced this issue Mar 22, 2024
@timotheeguerin @markcowl
Grammar: Fix comments in template params not tokenized (#3018)
e0dfe6f 
fix #3017

---------

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timotheeguerin timotheeguerin

Labels
None yet
Projects
None yet
Milestone
[2024] April
Development

Successfully merging a pull request may close this issue.

Grammar: Fix comments in template params not tokenized timotheeguerin/typespec
2 participants
@timotheeguerin @markcowl