Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg upgrade] overlay triplet on osx does not work when running vcpkg upgrade. #18764

Closed
daschuer opened this issue Jul 1, 2021 · 12 comments
Closed
Assignees
Labels
requires:repro The issue is not currently repro-able

Comments

@daschuer
Copy link
Contributor

daschuer commented Jul 1, 2021

Describe the bug

I am trying to us a overlay triplet for x64-osx
I have created overlay/triplets/x64-osx.cmake and set the environment variable VCPKG_OVERLAY_TRIPLETS to overlay/triplets

When building a port, I receive these lines:

[OVERLAY] Loading triplet configuration from: /Users/runner/mixxx-vcpkg/overlay/triplets/x64-osx.cmake
...
...
Error getting canonicalization of overlay/triplets: No such file or directory

Is it correct that the first line confirms that the file is there but it forgets it later on?

Environment

  • OS: osx
  • Compiler: GNU 11.1.0

To Reproduce
Steps to reproduce the behavior:
Use this workflow on github:
https://github.com/mixxxdj/vcpkg/blob/871675591e3fcc2b876d7a6f59cbe3518a142580/.github/workflows/build.yml

I am not able to provide a minimum failing receipt, because I have no access to an osx device.

Expected behavior
The overlay triplet should be used without failing

Failure logs
https://github.com/mixxxdj/vcpkg/runs/2960968025?check_suite_focus=true

Additional context
We need the overlay to set the VCPKG_OSX_DEPLOYMENT_TARGET to 10.12 for compatibility with old devices.

@JackBoosY JackBoosY added the requires:repro The issue is not currently repro-able label Jul 2, 2021
@JackBoosY
Copy link
Contributor

This issue cannot be reproduced by setting VCPKG_OVERLAY_TRIPLETS to an absolute path or a relative path.
But just in case, please make sure your vcpkg is up to date (and run bootstrap again) and set it as an absolute path and try again.

Thanks.

@daschuer
Copy link
Contributor Author

daschuer commented Jul 2, 2021

I will do.
Which OS did you try to reproduce it?
On Windows I cannot reproduce it either.

@JackBoosY
Copy link
Contributor

@daschuer On OSX.

@daschuer
Copy link
Contributor Author

daschuer commented Jul 5, 2021

The issue is fixed when using an absolute path.
See: https://github.com/daschuer/vcpkg/runs/2989211009?check_suite_focus=true

@JackBoosY
Copy link
Contributor

JackBoosY commented Jul 6, 2021

The issue is fixed when using an absolute path.
See: https://github.com/daschuer/vcpkg/runs/2989211009?check_suite_focus=true

I also test the relative path and it also works. No idea why it failed on your machine.
Any way, I will update the doc.

@JackBoosY JackBoosY added the category:documentation To resolve the issue, documentation will need to be updated label Jul 6, 2021
@JackBoosY JackBoosY changed the title overlay triplet on osx does not work. overlay triplet on osx does not work when running vcpkg upgrade. Jul 6, 2021
@JackBoosY JackBoosY removed the category:documentation To resolve the issue, documentation will need to be updated label Jul 6, 2021
@JackBoosY
Copy link
Contributor

@vicroms Can you please take a look?

Thanks.

@daschuer
Copy link
Contributor Author

daschuer commented Jul 6, 2021

It does not fail on my machine because I have no access to a osx device. It fails during a the GitHub workflow.

I have the suspicion that it relates to you other overlays since you cannot confirm it locally.
It fails when building /Users/runner/mixxx-vcpkg/overlay/osx/portmidi a osx enabled version.
See the [portmidi] commits here: https://github.com/mixxxdj/vcpkg/pull/18/commits
Can you spot an issue?
Do you have an idea to debug it?

@JackBoosY
Copy link
Contributor

Ping @vicroms

@daschuer
Copy link
Contributor Author

What does "requires:repro" mean?
Is anything missing?

@JackBoosY JackBoosY changed the title overlay triplet on osx does not work when running vcpkg upgrade. [vcpkg upgrade] overlay triplet on osx does not work when running vcpkg upgrade. Aug 26, 2021
@JackBoosY
Copy link
Contributor

@daschuer We couldn't reproduce this issue locally.

@LilyWangLL
Copy link
Contributor

Thanks for posting this issue. This issue hasn’t been updated in four months. Please reopen this issue if this is still a problem for you.

@daschuer
Copy link
Contributor Author

I can confirm that the issue is solved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires:repro The issue is not currently repro-able
Projects
None yet
Development

No branches or pull requests

5 participants