Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[utf8proc] CMake package version support #39176

Open
kou opened this issue Jun 7, 2024 · 1 comment
Open

[utf8proc] CMake package version support #39176

kou opened this issue Jun 7, 2024 · 1 comment
Assignees
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist depends:upstream-changes Waiting on a change to the upstream project

Comments

@kou
Copy link
Contributor

kou commented Jun 7, 2024

Is your feature request related to a problem? Please describe.

The utf8proc port adds support for CMake package by https://github.com/microsoft/vcpkg/blob/master/ports/utf8proc/export-cmake-targets.patch . So we can use find_package(unofficial-utf8proc) (or find_package(utf8proc NAMES unofficial-utf8proc)).

But it doesn't provide version information. So we can't specify required version such as find_package(unofficial-utf8proc 2.9.0).

Proposed solution

Could you also provide unofficial-utf8proc-version.cmake?
We can create it by write_basic_package_version_file().
See also: https://cmake.org/cmake/help/latest/module/CMakePackageConfigHelpers.html#command:write_basic_package_version_file

FYI: A PR that adds support for CMake package to upstream also uses it: JuliaStrings/utf8proc#260

Describe alternatives you've considered

No response

Additional context

No response

@kou kou added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jun 7, 2024
@MonicaLiu0311 MonicaLiu0311 added the depends:upstream-changes Waiting on a change to the upstream project label Jun 14, 2024
Copy link

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist depends:upstream-changes Waiting on a change to the upstream project
Projects
None yet
Development

No branches or pull requests

2 participants