[physx] Include error when compiling

[TokyoSU]

Describe the bug
When trying to compile a VS2022 project, it throw an error saying include is missing, after some investication, it seem like physx don't include physx/ at the start of the these include: #include "foundation/something.h" so to fix, i need to have a full path to include/physx added in "c/c++ additionals include directory".
that's not the optimal way since it need the username in the path.

Environment

• OS: Windows
• Compiler: Visual studio 2022 Community Edition

To Reproduce
Steps to reproduce the behavior:

1. vcpkg install physx:x86/64-windows
2. #include <physx/PxPhysicsAPI.h>
3. compile and see the error.

Expected behavior

Compiling without adding a full include path to physx.
vcpkg should include a path to include\physx.

Failure logs
None.

Additional context
None.

[JonLiu1993]

This is not a bug, you just need to #include <PxPhysicsAPI.h>.

vcpkg/ports/physx/omniverse-physx-sdk-config.cmake

Line 16 in a993be0

get_filename_component(OMNIVERSE-PHYSX-SDK_INCLUDE_DIRS "${z_vcpkg_omniverse_physx_sdk_prefix}/include/physx" ABSOLUTE)

vcpkg/ports/physx/omniverse-physx-sdk-config.cmake

Line 43 in a993be0

INTERFACE_INCLUDE_DIRECTORIES "${OMNIVERSE-PHYSX-SDK_INCLUDE_DIRS}"

[TokyoSU]

Sorry but "To Reproduce" do #include <PxPhysicsAPI.h> and cause that issue.
Take in account i don't use a cmake project but Visual studio with vcpkg integration.

[JonLiu1993]

@TokyoSU, Because of the configuration relationship between cmake project and MSbuild mode, when you reference header files in cmake project mode, you can only reference the "${z_vcpkg_omniverse_physx_sdk_prefix}/include/physx" layer, that is, #include <PxPhysicsAPI.h>.
When you reference header files in MSbuild mode, you can only apply to the ${VCPKG_ROOT_DIR}\installed\${TRIPLET}\include layer, that is, #include <physx/PxPhysicsAPI.h>. This is not a port bug, but a normal usage difference.

[dg0yt]

Many packages put headers into subdirs of include, and they export the location via CMake or pkg-config. That's fine.
msbuild is unable to use this exported information, and vcpkg doesn't change that so far. You must manually add the extra include dirs for such packages to the search path.

that is, #include <physx/PxPhysicsAPI.h>

If the package expects to be used with #include <PxPhysicsAPI.h>, then prefer to adjust the search path. Transitive #include <...> may assume that the search path is set correctly.

[github-actions]

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 28 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

[Sean-Slevin]

I've encountered the same issue.
The issue is that using visual studio after including PxPhysicsAPI.h as mentioned
#include <physx/PxPhysicsAPI.h>

This header then includes PxExtensionsAPI.h
#include "extensions/PxExtensionsAPI.h"

Which then includes PxCustomGeometryExt.h
#include "extensions/PxCustomGeometryExt.h"

Which then has 2 include statements that fail
#include <geometry/PxCustomGeometry.h>
#include <geometry/PxGjkQuery.h>

error C1083: Cannot open include file: 'geometry/PxCustomGeometry.h': No such file or directory

It seems the issue has been reported on the physx repo: NVIDIA-Omniverse/PhysX#285

I'm not sure if this is something vcpkg can solve but as is this package cannot be used with msbuild unless you
add include\physx to your include path.