Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gz-common5] Add include <chrono> for system_clock #42635

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WangWeiLin-MV
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV commented Dec 11, 2024

An issue revealed in microsoft/STL#5105, that can be fixed by including <chrono>.

include\gz\common5\gz/common/Event.hh(89): error C2039: 'system_clock': is not a member of 'std::chrono'

Submit upstream gazebosim/gz-common#655

Checklist

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Test

The port installation tests pass with the following triplets:

  • x64-windows

@WangWeiLin-MV WangWeiLin-MV added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. depends:upstream-changes Waiting on a change to the upstream project labels Dec 11, 2024
@WangWeiLin-MV WangWeiLin-MV removed the depends:upstream-changes Waiting on a change to the upstream project label Dec 13, 2024
@WangWeiLin-MV WangWeiLin-MV marked this pull request as ready for review December 13, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants