-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some Toolbar icons are not centered #139
Comments
I am happy to work on this issue if needed |
Transferring to the Codicons repo. |
Here's the basic problem. Codicons are built on an even pixel grid, which makes things challenging when you introduce elements that are supposed to sit directly in the middle. Current icon, offset by design to account for this: Here's how this looks if the container is perfectly even—you can't center the divider I may consider changing this icon anyway, but wanted to share the immediate challenge that I saw. |
Every time I mistake the problem for wrong padding and then arrive at this problem :) damn evens :)) |
Tracking in #243 |
Does this issue occur when all extensions are disabled?: Yes
These two icons are not centered in the toolbar. This occurs everywhere:
The text was updated successfully, but these errors were encountered: